Tardo / OdooTerminal

Webextension tool for Odoo
GNU Affero General Public License v3.0
119 stars 27 forks source link

[BUG] Pressing ESC on all pages will result in an error notification #134

Closed smomop closed 2 weeks ago

smomop commented 3 weeks ago

First of all, check that you are using the latest version.

Basic Info. (please complete the following information):

Describe the bug Pressing ESC on all pages will result in an error notification Expected behavior Do not encounter any errors

Screenshots

Additional context Error: CleanShot 2024-09-23 at 17 25 52@2x

Traceback: TypeError: Cannot read properties of undefined (reading 'classList') at Ys.hide (chrome-extension://fdidojpjkbpfplcdmeaaehnjfkgpbhad/dist/pub/loader.mjs:1:231352) at chrome-extension://fdidojpjkbpfplcdmeaaehnjfkgpbhad/dist/pub/loader.mjs:1:254008 at Generator.next (<anonymous>) at t (chrome-extension://fdidojpjkbpfplcdmeaaehnjfkgpbhad/dist/pub/constants-BWoluOSz.mjs:1:197) at a (chrome-extension://fdidojpjkbpfplcdmeaaehnjfkgpbhad/dist/pub/constants-BWoluOSz.mjs:1:400) at chrome-extension://fdidojpjkbpfplcdmeaaehnjfkgpbhad/dist/pub/constants-BWoluOSz.mjs:1:459 at new Promise (<anonymous>) at chrome-extension://fdidojpjkbpfplcdmeaaehnjfkgpbhad/dist/pub/constants-BWoluOSz.mjs:1:340 at jl.doHide (chrome-extension://fdidojpjkbpfplcdmeaaehnjfkgpbhad/dist/pub/loader.mjs:1:254017) at jl.kl (chrome-extension://fdidojpjkbpfplcdmeaaehnjfkgpbhad/dist/pub/loader.mjs:1:262478)

Tardo commented 3 weeks ago

It seems that the extension is not starting correctly. Does the browser console throw any other messages since the page starts loading?

Does the bug happen in Odoo runbot (https://runbot.odoo.com/)?

Thank you.

smomop commented 3 weeks ago

It seems that the extension is not starting correctly. Does the browser console throw any other messages since the page starts loading?

Does the bug happen in Odoo runbot (https://runbot.odoo.com/)?

Thank you.

Console Information CleanShot 2024-09-24 at 08 47 38@2x

runbot pages CleanShot 2024-09-24 at 08 46 59@2x When I disable this extension CleanShot 2024-09-24 at 08 48 32@2x

colu-odoo commented 3 weeks ago

Same issue in Firefox

Tardo commented 2 weeks ago

Thanks for reporting! :) Fixed here: https://github.com/Tardo/OdooTerminal/commit/97a30c2f4237a078a6829cd547b7daf69078b801

Releasing v11.5.2...