TareHimself / manga-translator

A manga translator built with python
GNU General Public License v3.0
74 stars 12 forks source link

Cbz Support Request #46

Open gynom opened 1 month ago

gynom commented 1 month ago

Can you add support for cbz files? Also known as comic book archives.

They are zip files with a changed extension to .cbz they generally have images with names 01.jpg 02.jpg 03.jpg 04.jpg (Doesn't have to be jpg)

I can upload a cbz file/zip file so you can take a look. Also I recommend using 7z.exe to extract the images and to zip them, just cuz it's faster.

Make sure that it is a zip file not a 7z file if you plan to use it. Also make sure it changes the extension after so back to cbz.

Also this is just a request if you don't wanna do it just close the issue.

(I'm uploading it with a .zip extension because github says "We don’t support that file type." even tho it technically is a zip file but whatever)

Vol.01 Ch.0001 - The Loner Noble Dies a Lonely Death (en).zip

TareHimself commented 1 month ago

I can give it a try, but if they are just zip files I can use Python zip.

gynom commented 1 month ago

You can use python zip, BUT 7z.exe is a lot faster than python zip like 5x times faster. (Only tested on my slow 10 framerate laptop so not sure if it actually is but I assume it's the same.) If you don't know what 7z.exe is it's like 7zip but the terminal version. You could use subprocess on it? Since 7z is cross platform you could also download linux version and support for that, but it is easier to use python zip.