TarekRaafat / autoComplete.js

Simple autocomplete pure vanilla Javascript library.
https://tarekraafat.github.io/autoComplete.js
Apache License 2.0
3.95k stars 240 forks source link

doesn't persist the input type, always changes input to type=text #180

Closed adardesign closed 3 years ago

adardesign commented 3 years ago

Was there any reason that the code changes the input type to text?

Type search comes with native styles and features (like clear button)

image

Here is the line in the source that changes the type

TarekRaafat commented 3 years ago

Hello @adardesign,

Good point.

So, what do you suggest shall we change the input type to be search instead of text or just remove it and leave it open to personal preferences?

Cheers, have a nice day! :)

adardesign commented 3 years ago

I'd suggest leaving it open to personal preferences

Thanks!

adardesign commented 3 years ago

https://github.com/adardesign/autoComplete.js/pull/1