search

TarikHuber / rmw-shell

Shell of main components for the React Most Wanted project
26 stars 23 forks source link

Move Chat from rmw-shell to demo #27

Open mradenovic opened 5 years ago

mradenovic commented 5 years ago

I like this project and I would like to use it in my project. However, I don't need a chat functionality and I would like to remove it. I guess that when it was just a react-most-wanted boilerplate, it was easy to change everything. I started with react-most wanted boilerplate, and it was not obvious how to use firebase storage (hidden in chat).

It looks like there is no easy way to do it without changing rmw-shell. I would like to work on it if it is a possible solution. I understand that it might affect projects that are based on rmw-shell.

The bigest benifit is that How to use it? would be in demo and How it works? would be in shell.The best would be probably to make Chat (and anything else not essential) installable with react-scripts:

TarikHuber commented 5 years ago

Hi,

It is very easy to remove it. You can override every path. To remove the chat just redirect/revrite the chat paths to a "page not found" component or something else you want.

But any help to organize this project is welcome 😁

Mischa Radenovic notifications@github.com schrieb am Di., 4. Juni 2019, 03:57:

I like this project and I would like to use it in my project. However, I don't need a chat functionality and I would like to remove it. I guess that when it was just a react-most-wanted https://github.com/TarikHuber/react-most-wanted boilerplate, it was easy to change everything. I started with react-most wanted boilerplate, and it was not obvious how to use firebase storage (hidden in chat).

It looks like there is no easy way to do it without changing rmw-shell. I would like to work on it if it is a possible solution. I understand that it might affect projects that are based on rmw-shell.

The bigest benifit is that How to use it? would be in demo and How it works? would be in shell.The best would be probably to make Chat (and anything else not essential) installable with react-scripts:

  • npx create-react-app test-app --scripts-version rmw-chat-react-scripts
  • npx create-react-app test-app --scripts-version rmw-database-react-scripts
  • npx create-react-app test-app --scripts-version rmw-firestore-react-scripts
  • ...
  • npx create-react-app test-app --scripts-version rmw-storage-react-scripts

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/TarikHuber/rmw-shell/issues/27?email_source=notifications&email_token=ACVV54XGMXK7BDFTBV53LMTPYXDYXA5CNFSM4HSXHBC2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GXNKVPQ, or mute the thread https://github.com/notifications/unsubscribe-auth/ACVV54RHG7BMNRZO4ZLMKXLPYXDYXANCNFSM4HSXHBCQ .