search

Taritsyn / JavaScriptEngineSwitcher

JavaScript Engine Switcher determines unified interface for access to the basic features of popular JavaScript engines. This library allows you to quickly and easily switch to using of another JavaScript engine.
Apache License 2.0
440 stars 49 forks source link

NuGet package is built in debug mode #38

Closed gunnim closed 7 years ago

gunnim commented 7 years ago

Is there a reason for this? Seems like it would be better to distribute the package in release mode.

(I checked with a directory scanning fork of https://assemblyinformation.codeplex.com/)

Taritsyn commented 7 years ago

Hello, Gunnar!

All assemblies for the packages I'm building in release mode. In which package did you find this problem?

gunnim commented 7 years ago

ru-ru\JavaScriptEngineSwitcher.Core.resources.dll for netstandard 1.3 and net45

gunnim commented 7 years ago

Should've been more specific initially. I just gave the results a cursory look and didn't notice it wasn't the main assemblies :)

Taritsyn commented 7 years ago

Look a source code of script to build the JavaScriptEngineSwitcher.Core package. You can see, that everywhere are used directories with the release assemblies.

gunnim commented 7 years ago

Interesting....

But as you can see here it still seems to have been uploaded to nuget without optimizations. Same applies to your latest 3.0.0-alpha1 build But.. since it's just a resource assembly i guess it isn't a big deal but noteworthy nonetheless :)

image

Daniel15 commented 7 years ago

@gunnim - This is just a resource assembly and only contains a resource file with strings in it. It does not contain any code, so there's no difference between a debug and a release build. The framework might always compile them in debug mode because of that.

gunnim commented 7 years ago

@Daniel15 Makes sense, I definately jumped the gun with this issue. I had just completed a scan and found dozens of other packages that had their core assemblies released in debug mode, so i was kindof in autopilot mode notifying maintainers :).

Taritsyn commented 7 years ago

@gunnim @Daniel15 It seems that this is a bug in dotnet.exe. Moreover, if build a library by using Visual Studio 2017, then there is no such error.