search

Taritsyn / JavaScriptEngineSwitcher

JavaScript Engine Switcher determines unified interface for access to the basic features of popular JavaScript engines. This library allows you to quickly and easily switch to using of another JavaScript engine.
Apache License 2.0
440 stars 49 forks source link

System.Runtime.InteropServices.RuntimeInformation not required for .NET Framework 4.7.1 #54

Closed flcdrg closed 6 years ago

flcdrg commented 6 years ago

I believe this NuGet package wouldn't be required when targetting 4.7.1 as it it built in

https://docs.microsoft.com/en-au/dotnet/api/system.runtime.interopservices.runtimeinformation?view=netframework-4.7.1

Taritsyn commented 6 years ago

Hello, David!

Does dependency on the System.Runtime.InteropServices.RuntimeInformation package lead to any conflicts or errors in your project?

flcdrg commented 6 years ago

Yes, you end up with a reference to the assembly, but also a warning that it can't find it (which is a strange warning as the file is sitting there).

image

There's also info logged if you do a command-line build:

Encountered conflict between 'Reference:System.Runtime.InteropServices.RuntimeInformation, Version=4.0.0.0, Culture=n eutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL' and 'Platform:System.Runtime.InteropServices.Run timeInformation.dll'. Choosing 'Platform:System.Runtime.InteropServices.RuntimeInformation.dll' because AssemblyVers ion '4.0.2.0' is greater than '4.0.0.0'.

Taritsyn commented 6 years ago

OK. Thanks for information!

Taritsyn commented 6 years ago

Hello, David!

This fix was included in version 3.0.0 Beta 4.

flcdrg commented 6 years ago

Awesome!