search

Taritsyn / WebMarkupMin

The Web Markup Minifier (abbreviated WebMarkupMin) - a .NET library that contains a set of markup minifiers. The objective of this project is to improve the performance of web applications by reducing the size of HTML, XHTML and XML code.
Apache License 2.0
447 stars 48 forks source link

Minification not working - config issue? #50

Closed christopherdude closed 6 years ago

christopherdude commented 6 years ago

I'm sure this is something that I'm doing, however, implementing either master or page compiles and runs fine, but doesn't do minification. I plugged in the config and put it through global, but still nothing happens. Clues?

Taritsyn commented 6 years ago

Hello, Christopher!

I'm sure this is something that I'm doing, however, implementing either master or page compiles and runs fine, but doesn't do minification.

Most likely, your web application is in debug mode. See a the “ASP.NET 4.X Extensions > WebMarkupMin configuration” subsection of documentation.

I recommend you read the following sections of documentation: “ASP.NET Extensions”, “ASP.NET 4.X Extensions” and “WebMarkupMin: ASP.NET 4.X Web Forms”.

I plugged in the config and put it through global, but still nothing happens.

If you are still using version 1.X, then you should upgrade to version 2.X. About how to do this, see the “How to upgrade applications to version 2.X” section of documentation.

christopherdude commented 6 years ago

Brilliant, that worked (debug). I should have seen that. Last question – does it minimize the WebResource.axd file, or is there a configuration / setting to ask it to?

From: Andrey Taritsyn [mailto:notifications@github.com] Sent: Sunday, November 12, 2017 12:40 AM To: Taritsyn/WebMarkupMin WebMarkupMin@noreply.github.com Cc: Chris Dengler losdudechris@hotmail.com; Author author@noreply.github.com Subject: Re: [Taritsyn/WebMarkupMin] Minification not working - config issue? (#50)

Hello, Christopher!

I'm sure this is something that I'm doing, however, implementing either master or page compiles and runs fine, but doesn't do minification.

Most likely, your web application is in debug mode. See a the “ASP.NET 4.X Extensions > WebMarkupMin configuration”https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FTaritsyn%2FWebMarkupMin%2Fwiki%2FASP.NET-4.X-Extensions%23webmarkupmin-configuration&data=02%7C01%7Closdudechris%40hotmail.com%7C4c3edc0f77c840c5dd8408d529a0a42f%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636460692276630358&sdata=e8%2BNqLAzBMHOez9Nr7E6wJ%2FH2Tzo%2FzpeiElGmNVvFkM%3D&reserved=0 subsection of documentation.

I recommend you read the following sections of documentation: “ASP.NET Extensions”https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FTaritsyn%2FWebMarkupMin%2Fwiki%2FASP.NET-Extensions&data=02%7C01%7Closdudechris%40hotmail.com%7C4c3edc0f77c840c5dd8408d529a0a42f%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636460692276630358&sdata=cPtweSekfN04QTcnxff4ITh2CXnh%2FsKPsabboSnC3A4%3D&reserved=0, “ASP.NET 4.X Extensions”https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FTaritsyn%2FWebMarkupMin%2Fwiki%2FASP.NET-4.X-Extensions&data=02%7C01%7Closdudechris%40hotmail.com%7C4c3edc0f77c840c5dd8408d529a0a42f%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636460692276630358&sdata=BCdyVVbW%2FBOeBLyB2qhvvORY6OZK1ekzYZO6ThAGn9M%3D&reserved=0 and “WebMarkupMin: ASP.NET 4.X Web Forms”https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FTaritsyn%2FWebMarkupMin%2Fwiki%2FWebMarkupMin%3A-ASP.NET-4.X-Web-Forms&data=02%7C01%7Closdudechris%40hotmail.com%7C4c3edc0f77c840c5dd8408d529a0a42f%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636460692276630358&sdata=vZpzeFn8DQ1r%2BFNfZsBKgwF%2FEtN7IV%2FMYAggNERT554%3D&reserved=0.

I plugged in the config and put it through global, but still nothing happens.

If you are still using version 1.X, then you should upgrade to version 2.X. About how to do this, see the “How to upgrade applications to version 2.X”https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FTaritsyn%2FWebMarkupMin%2Fwiki%2FHow-to-upgrade-applications-to-version-2.X&data=02%7C01%7Closdudechris%40hotmail.com%7C4c3edc0f77c840c5dd8408d529a0a42f%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636460692276630358&sdata=t8ZlVQ2b1h5oPz7rB%2FA%2FMwQ0z2oks2KZ71ZVUBJZ2wY%3D&reserved=0 section of documentation.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FTaritsyn%2FWebMarkupMin%2Fissues%2F50%23issuecomment-343719293&data=02%7C01%7Closdudechris%40hotmail.com%7C4c3edc0f77c840c5dd8408d529a0a42f%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636460692276630358&sdata=Uc3fjrCMKcLHRTkjkmo9NfIfGQmt8DGg1Zc%2Bqp%2FU87Y%3D&reserved=0, or mute the threadhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAJGPH8msxRk1LarvnQYHOC9g7-SAnRQqks5s1qDpgaJpZM4Qao-j&data=02%7C01%7Closdudechris%40hotmail.com%7C4c3edc0f77c840c5dd8408d529a0a42f%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636460692276630358&sdata=hH4rHdq46BydWGUFgd1Tw1GCmzvF%2BnkGDz32uJOTP8s%3D&reserved=0.

Taritsyn commented 6 years ago

Hello, Christopher!

Last question – does it minimize the WebResource.axd file, or is there a configuration / setting to ask it to?

As I understand, you did not read the README.md? WebMarkupMin minifies only markup of pages (HTML, XHTML and XML code). In addition, HTML and XHTML minifiers supports the minification of CSS code from style tags and attributes, and minification of JavaScript code from script tags, event attributes and hyperlinks with javascript: protocol.

Do not confuse the WebMarkupMin with the WebOptimizer.NET.

christopherdude commented 6 years ago

Yes, I read it and understood it. But please understand that the WebResource.axd file produces a script tag with JavaScript contents, ergo my question regarding whether or not this tool minimizes the output. It’s a legitimate question.

For example, if we know that a particular file with a particular extension (in this case WebResource.axd) always produces JavaScript, would it not be safe to ask whether or not this tool might be able to target such a specific file to let it know that it is a JavaScript file and that we are requesting that it will get minimized? You stated that it does minification of JavaScript; this is indeed JavaScript.

However, what I believe you’re saying is that this tool can do minification of INLINE JavaScript, not JavaScript generated in separate files on the fly?

From: Andrey Taritsyn [mailto:notifications@github.com] Sent: Monday, November 13, 2017 1:15 AM To: Taritsyn/WebMarkupMin WebMarkupMin@noreply.github.com Cc: Chris Dengler losdudechris@hotmail.com; Author author@noreply.github.com Subject: Re: [Taritsyn/WebMarkupMin] Minification not working - config issue? (#50)

Hello, Christopher!

Last question – does it minimize the WebResource.axd file, or is there a configuration / setting to ask it to?

As I understand, you did not read the README.mdhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FTaritsyn%2FWebMarkupMin%2Fblob%2Fmaster%2FREADME.md&data=02%7C01%7Closdudechris%40hotmail.com%7C1fa4ed162dde4e8f99c608d52a6e9d31%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636461576924885487&sdata=hd%2BayPJTcVJ2MvftUK7LGDHP2Q4d4wRKwphewvM0S%2FE%3D&reserved=0? WebMarkupMin minifies only markup of pages (HTML, XHTML and XML code). In addition, HTML and XHTML minifiers supports the minification of CSS code from style tags and attributes, and minification of JavaScript code from script tags, event attributes and hyperlinks with javascript: protocol.

Do not confuse the WebMarkupMin with the WebOptimizer.NEThttps://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fweboptimizer.codeplex.com%2F&data=02%7C01%7Closdudechris%40hotmail.com%7C1fa4ed162dde4e8f99c608d52a6e9d31%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636461576924885487&sdata=u%2BiCJeAVnKWGVZjkmE7km5R5BrvEB67AQnWZvbgL4uI%3D&reserved=0.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FTaritsyn%2FWebMarkupMin%2Fissues%2F50%23issuecomment-343843529&data=02%7C01%7Closdudechris%40hotmail.com%7C1fa4ed162dde4e8f99c608d52a6e9d31%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636461576924885487&sdata=kl1qBAlpYE4uB0sKzTyrzePInNxQVXCokMrJvvaTSo8%3D&reserved=0, or mute the threadhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAJGPH6k3HYOCQd7YRgqqkJ9ySvkHi_Veks5s1_p5gaJpZM4Qao-j&data=02%7C01%7Closdudechris%40hotmail.com%7C1fa4ed162dde4e8f99c608d52a6e9d31%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636461576924885487&sdata=pDN5dZk3Jo1KzIeyEGJE6%2Fl74mM5mDJFfSgJh4Rly90%3D&reserved=0.

Taritsyn commented 6 years ago

Yes, I read it and understood it. But please understand that the WebResource.axd file produces a script tag with JavaScript contents, ergo my question regarding whether or not this tool minimizes the output. It’s a legitimate question.

What media-type (Content-Type) have this the WebResource.axd file?

Taritsyn commented 6 years ago

However, what I believe you’re saying is that this tool can do minification of INLINE JavaScript, not JavaScript generated in separate files on the fly?

Yes, only embedded and inline JavaScript code. Perhaps you need to try the WebMarkupMin.AspNet4.HttpModules module instead of the WebMarkupMin.AspNet4.WebForms module. And then experiment with settings from the “ASP.NET Extensions > Managers and options” subsection of documentation.

If you need to minify pure JavaScript code, then see the following libraries: Microsoft Ajax Minifier, YUI Compressor for .Net, NUglify or JSMin for .NET.

christopherdude commented 6 years ago

I’m already minimizing all JS and CSS. The problem is, the WebResource.axd creates JS on the fly. I just need to interrupt that process and minimize before it outputs. I’ll look into these below. Thanks!

From: Andrey Taritsyn [mailto:notifications@github.com] Sent: Tuesday, November 14, 2017 1:13 PM To: Taritsyn/WebMarkupMin WebMarkupMin@noreply.github.com Cc: Chris Dengler losdudechris@hotmail.com; Author author@noreply.github.com Subject: Re: [Taritsyn/WebMarkupMin] Minification not working - config issue? (#50)

However, what I believe you’re saying is that this tool can do minification of INLINE JavaScript, not JavaScript generated in separate files on the fly?

Yes, only embedded and inline JavaScript code. Perhaps you need to try the WebMarkupMin.AspNet4.HttpModuleshttps://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FTaritsyn%2FWebMarkupMin%2Fwiki%2FWebMarkupMin%3A-ASP.NET-4.X-HTTP-modules&data=02%7C01%7Closdudechris%40hotmail.com%7C7178faf1516347842f5508d52b9c15ce%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636462871730708675&sdata=AsY6M2GB4bJ4WPNwk9vveUYUTyWiJ%2FmD7p5fOBocwTA%3D&reserved=0 module instead of the WebMarkupMin.AspNet4.WebForms module. And then experiment with settings from the “ASP.NET Extensions > Managers and options”https://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FTaritsyn%2FWebMarkupMin%2Fwiki%2FASP.NET-Extensions%23managers-and-options&data=02%7C01%7Closdudechris%40hotmail.com%7C7178faf1516347842f5508d52b9c15ce%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636462871730708675&sdata=KYpQ1DIpUVRoSbaYvDMGerJS0nWrGetafFarFK70vsc%3D&reserved=0 subsection of documentation.

If you need to minify pure JavaScript code, then see the following libraries: Microsoft Ajax Minifierhttps://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fajaxmin.codeplex.com%2F&data=02%7C01%7Closdudechris%40hotmail.com%7C7178faf1516347842f5508d52b9c15ce%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636462871730708675&sdata=jXQaWrvsJ8ERy94Kis2QITsC8p2M0WfSZIRFxu7Lvy8%3D&reserved=0, YUI Compressor for .Nethttps://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FPureKrome%2FYUICompressor.NET&data=02%7C01%7Closdudechris%40hotmail.com%7C7178faf1516347842f5508d52b9c15ce%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636462871730708675&sdata=cn29jPkidtZnyfpSfum0RffYGdyrkr6Qwgaw%2FoFo7No%3D&reserved=0, NUglifyhttps://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fxoofx%2FNUglify&data=02%7C01%7Closdudechris%40hotmail.com%7C7178faf1516347842f5508d52b9c15ce%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636462871730708675&sdata=FaSrtMbQSx0w4YL08VtUAH9uDSzkrMcGmbbMb8eSfok%3D&reserved=0 or JSMin for .NEThttps://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FTaritsyn%2FJSMin.NET&data=02%7C01%7Closdudechris%40hotmail.com%7C7178faf1516347842f5508d52b9c15ce%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636462871730708675&sdata=Qdrqm84nJefJSvzJogl8Ya46YZ9erBhoJ6aRHhkDVSE%3D&reserved=0.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FTaritsyn%2FWebMarkupMin%2Fissues%2F50%23issuecomment-344383348&data=02%7C01%7Closdudechris%40hotmail.com%7C7178faf1516347842f5508d52b9c15ce%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636462871730708675&sdata=vr6ot9aAFBttaCf%2B5W54zIoNW5%2Bxzm7Q7zg3TPHcG%2Bs%3D&reserved=0, or mute the threadhttps://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAJGPH3ptYyroH0Juf9-ICt9530AU5H43ks5s2fRDgaJpZM4Qao-j&data=02%7C01%7Closdudechris%40hotmail.com%7C7178faf1516347842f5508d52b9c15ce%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636462871730708675&sdata=ItzmAPFgKFcq6WauRNtbZMJhJWKsq9Uo2N7RtceHYv0%3D&reserved=0.