Closed wonderplayer closed 1 year ago
Merging #113 (e96b77b) into main (694ec0f) will increase coverage by
0.18%
. The diff coverage is79.36%
.
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@ Coverage Diff @@
## main #113 +/- ##
========================================
+ Coverage 0.75% 0.93% +0.18%
========================================
Files 130 131 +1
Lines 8722 8740 +18
========================================
+ Hits 66 82 +16
- Misses 8656 8658 +2
Impacted Files | Coverage Δ | |
---|---|---|
...sthaven_assistant/lib/services/network/client.dart | 2.10% <0.00%> (ø) |
|
...sthaven_assistant/lib/services/network/server.dart | 0.00% <0.00%> (ø) |
|
...thaven_assistant/lib/services/service_locator.dart | 14.28% <0.00%> (-2.39%) |
:arrow_down: |
..._assistant/lib/services/network/communication.dart | 83.33% <73.33%> (-10.15%) |
:arrow_down: |
...ven_assistant/lib/services/network/connection.dart | 100.00% <100.00%> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
So, having Sockets in memory poses challenges in testing. Thus, extracted to separate module, so I can later on replace in-memory sockets with storing them in files to make them state-less. But definitely not right now, as will add additional file system complexity.