search

Tarobish / Jomhuria

http://tarobish.github.io/Jomhuria/
SIL Open Font License 1.1
23 stars 6 forks source link

Position of marks #19

Closed Tarobish closed 9 years ago

Tarobish commented 9 years ago

There is Collision with the position of marks in the Arabic when two marks, are coming above and under each other in the same place.

graphicore commented 9 years ago

How can I reproduce this?

Tarobish commented 9 years ago

I belive some features has broken. They are in the right position but they don’t works together. we need to ask Khaled

On Jun 20, 2015, at 11:17 AM, Lasse Fister notifications@github.com wrote:

How can I reproduce this?

— Reply to this email directly or view it on GitHub https://github.com/Tarobish/Jomhuria/issues/19#issuecomment-113799419.

graphicore commented 9 years ago

Can you show it to me? Or give a string (text) to reproduce it. I'm thinking we may need a little input box widget to make this kind of work easier...

we need to ask Khaled

I probably can figure it out, once I can reproduce it myself.

graphicore commented 9 years ago

I almost forgot to mention this here. I used the marks.txt to create a pdf and an html test:

https://github.com/Tarobish/Jomhuria/blob/master/generated/documents/marks.pdf http://tarobish.github.io/Jomhuria/#texts/marks1

It's certainly no good type setting, but I hope its sufficient to identify problems.

@Tarobish tell me, where are the problems?

Tarobish commented 9 years ago

I checked the whole pdf, looks great. many thanks, i didn't find any problem :)

On Jun 23, 2015, at 11:05 AM, Lasse Fister notifications@github.com wrote:

I almost forgot to mention this here. I used the marks.txt to create a pdf and an html test:

https://github.com/Tarobish/Jomhuria/blob/master/generated/documents/marks.pdf https://github.com/Tarobish/Jomhuria/blob/master/generated/documents/marks.pdf http://tarobish.github.io/Jomhuria/#texts/marks1 http://tarobish.github.io/Jomhuria/#texts/marks1 It's certainly no good type setting, but I hope its sufficient to identify problems.

@Tarobish https://github.com/Tarobish tell me, where are the problems?

— Reply to this email directly or view it on GitHub https://github.com/Tarobish/Jomhuria/issues/19#issuecomment-114592584.

graphicore commented 9 years ago

So, what's to do here? I did not work this issue (consciously). Can we close this again?

graphicore commented 9 years ago

Closing for being inactive, also "looks great. many thanks" implies that this was dealt with.