search

Tarobish / Jomhuria

http://tarobish.github.io/Jomhuria/
SIL Open Font License 1.1
23 stars 6 forks source link

Some Marks are not correct positioned #20

Closed graphicore closed 9 years ago

graphicore commented 9 years ago

http://tarobish.github.io/Jomhuria/#tests/collision-below-2

Alef uni0671.fina and Alef uni0622.fina. The uni0622.fina Alef with Madda above is also misbehaving in combination with uni0655 (first row in each section)

graphicore commented 9 years ago

Not also. The uniF*** and u1EE** I wont fix in this regard, because:

@khaledhosny wrote:

BTW, don’t bother testing mark positioning with uniF* glyphs

Tarobish commented 9 years ago

i checked them all it is a same problem, it works perfectly alone but it doesn’t when it comes with Madda or Hamza.wasl above. or uni 0651 (shahada) it look perfect in the Anchor control window (with TashkilTashkil above or below) but as you see in the sample (with white background) it doesn’t or uni 064F.

On Jun 20, 2015, at 11:52 AM, Lasse Fister notifications@github.com wrote:

Not also. The uniF** and u1EE* I wont fix in this regard, because:

@khaledhosny https://github.com/khaledhosny wrote:

BTW, don’t bother testing mark positioning with uniF* glyphs

— Reply to this email directly or view it on GitHub https://github.com/Tarobish/Jomhuria/issues/20#issuecomment-113804187.

graphicore commented 9 years ago

Did you attach an image? Go to: https://github.com/Tarobish/Jomhuria/issues/20 and drag it into a comment field. It seems that images don't survive email-posting.

Tarobish commented 9 years ago

screen shot 2015-06-20 at 12 02 22 pm screen shot 2015-06-20 at 12 03 03 pm screen shot 2015-06-20 at 12 00 08 pm screen shot 2015-06-20 at 12 07 22 pm screen shot 2015-06-20 at 11 59 07 am screen shot 2015-06-20 at 11 55 49 am

graphicore commented 9 years ago

Not how in the second row from the right collide. I fixed that in 8e79123b by adding a lot of TashkilTashkilBelow marks to the Mark characters. This is actually the only column in the table that does mark to mark positioning, that's why we don't have the problem anywhere else.

The uni0622.fina alef with madda above in the 6th column from the right. In the first line I reversed some normalization that took place, to get the actual uni0622.fina glyph shaped c045e6c649b4

Then for Alef uni0622.fina and uni0671.fina , 6th row and last row from the right in the screenshot, I added the missing base anchors TashkilAbove and TashkilBelow in 4e6b5cf25

Old:

selection_065

New:

selection_066

graphicore commented 9 years ago

@Tarobish The last screenshot that you posted here. That has probably also to do with missing anchors.

However, I think I fixed only mark to mark positioning below the baseline. Do we need this? Should I make one or two mark to mark test tables?

Tarobish commented 9 years ago

I belive, we are good. we are done with the "Alef" ;) but if you think we have to add more test table, please do it. up to you :) we still have the same problem with position of marks (screenshot المفرد )

On Jun 23, 2015, at 6:20 PM, Lasse Fister notifications@github.com wrote:

@Tarobish https://github.com/Tarobish The last screenshot that you posted here. That has probably also to do with missing anchors.

However, I think I fixed only mark to mark positioning below the baseline. Do we need this? Should I make one or two mark to mark test tables?

— Reply to this email directly or view it on GitHub https://github.com/Tarobish/Jomhuria/issues/20#issuecomment-114691357.

graphicore commented 9 years ago

Ok, good. We should do lazy evaluation here and close this. If anything is not working in real world scenarios, we can still fix it later. The bug tracker is open.