search

Tarobish / Jomhuria

http://tarobish.github.io/Jomhuria/
SIL Open Font License 1.1
22 stars 6 forks source link

The placement of U+0620 ring is incorrect #26

Closed khaledhosny closed 9 years ago

khaledhosny commented 9 years ago

The ring here should be detached from the base i.e. like a dot, unlike other letters with a ring below.

graphicore commented 9 years ago

@khaledhosny does this look allright:

http://tarobish.github.io/Jomhuria/#live?eyJ2YWx1ZSI6IiYjeDA2MjA7XG48c3BhbiBzdHlsZT1cImZvbnQtZmFtaWx5OiBBbWlyaVwiPiYjeDA2MjA7PC9zcGFuPiIsImJpZGkiOiJydGwiLCJsYW5nIjoiYXIifQ==

selection_006

(Amiri on the left)

khaledhosny commented 9 years ago

Yes, looks fine, but make sure all forms of the character does so as well.

graphicore commented 9 years ago

I see.

graphicore commented 9 years ago

Here is the complete case

http://tarobish.github.io/Jomhuria/#live?eyJ2YWx1ZSI6IiYjeDA2MjA7ICAmI3gwNjIwOyYjODIwNTsgICAmIzgyMDU7JiN4MDYyMDsmIzgyMDU7ICAmIzgyMDU7JiN4MDYyMDsgXG5cbjxzcGFuIHN0eWxlPVwiZm9udC1mYW1pbHk6IEFtaXJpXCI+JiN4MDYyMDsgICYjeDA2MjA7JiM4MjA1OyAgICYjODIwNTsmI3gwNjIwOyYjODIwNTsgICYjODIwNTsmI3gwNjIwOyA8L3NwYW4+IiwiYmlkaSI6InJ0bCIsImxhbmciOiJhciJ9

selection_007

khaledhosny commented 9 years ago

Just compare it to ي, the ring should be positioned similar to the dots. You might also need to check any alternate glyphs for those.

http://tarobish.github.io/Jomhuria/#live?eyJ2YWx1ZSI6IiYjeDA2MjA7ICAmI3gwNjIwOyYjODIwNTsgICAmIzgyMDU7JiN4MDYyMDsmIzgyMDU7ICAmIzgyMDU7JiN4MDYyMDsgXG5cbiYjeDA2NEE7ICAmI3gwNjRBOyYjODIwNTsgICAmIzgyMDU7JiN4MDY0QTsmIzgyMDU7ICAmIzgyMDU7JiN4MDY0QTsgIiwiYmlkaSI6InJ0bCIsImxhbmciOiJhciJ9

graphicore commented 9 years ago

I was just about to push this:

selection_008

I also fixed the alternative forms.

graphicore commented 9 years ago

right, a push to gh-pages closes this issue ... reopened

khaledhosny commented 9 years ago

Looks good.

graphicore commented 9 years ago

great, thanks