Arabic subtending marks are broken

khaledhosny commented 9 years ago

[x] The glyphs have -ve side bearing which will cause them to overlap with neighbouring glyphs. The side bearings should be +ve (or zero at least).
[x] The positioning rules of the digits needs to be adjusted as the existing one are copied from amiri and they are specific to Amiri’s glyph widths.

graphicore commented 9 years ago

Here is an initial case:

http://tarobish.github.io/Jomhuria/#live?eyJ2YWx1ZSI6InxKb21odXJpYXw8c3BhbiBzdHlsZT1cImZvbnQtZmFtaWx5OiBBbWlyaVwiPkFtaXJpPC9zcGFuPnxcbnwtLXwtLXxcbnwg2aHZotmj2aR8PHNwYW4gc3R5bGU9XCJmb250LWZhbWlseTogQW1pcmlcIj7Zodmi2aPZpDwvc3Bhbj58XG58JiN4MDYwMDvZodmi2aPZpOKArOKArHw8c3BhbiBzdHlsZT1cImZvbnQtZmFtaWx5OiBBbWlyaVwiPiYjeDA2MDA72aHZotmj2aTigKzigKw8L3NwYW4+fFxufCYjeDA2MDE72aHZotmj2aTigKzigKx8PHNwYW4gc3R5bGU9XCJmb250LWZhbWlseTogQW1pcmlcIj4mI3gwNjAxO9mh2aLZo9mk4oCs4oCsPC9zcGFuPnxcbnwmI3gwNjAyO9mh2aJ8PHNwYW4gc3R5bGU9XCJmb250LWZhbWlseTogQW1pcmlcIj4mI3gwNjAyO9mh2aI8L3NwYW4+fFxufCYjeDA2MDM72aHZotmjfDxzcGFuIHN0eWxlPVwiZm9udC1mYW1pbHk6IEFtaXJpXCI+JiN4MDYwMzvZodmi2aPigKzigKzigKzigKw8L3NwYW4+fFxufCYjeDA2ZGQ72aHZotmj4oCs4oCsfDxzcGFuIHN0eWxlPVwiZm9udC1mYW1pbHk6IEFtaXJpXCI+JiN4MDZkZDvZodmi2aM8L3NwYW4+fFxuXG5cblxuXG5cblxuXG5cblxuXG5cblxuIiwiYmlkaSI6InJ0bCIsImxhbmciOiJhciJ9

selection_009

I'll do my best, because I think this is hard to do for @Tarobish; given the handwritten nature of the mentioned positioning rules.

Tarobish commented 9 years ago

:) Thanks

On Sep 21, 2015, at 3:58 PM, Lasse Fister notifications@github.com wrote:

Here is an initial case:

http://tarobish.github.io/Jomhuria/#live?eyJ2YWx1ZSI6InxKb21odXJpYXw8c3BhbiBzdHlsZT1cImZvbnQtZmFtaWx5OiBBbWlyaVwiPkFtaXJpPC 9zcGFuPnxcbnwtLXwtLXxcbnwg2aHZotmj2aR8PHNwYW4gc3R5bGU9XCJmb250LWZhbWlseTogQW1pcmlcIj7Zodmi2aPZpDwvc3Bhbj58XG58JiN4MDYwMDvZodmi2aPZpOKArOKArHw8c3BhbiBzdHlsZT1cImZvbnQtZmFtaWx5OiBBbWlyaVwiPiYjeDA2MDA72aHZotmj2aTigKzigKw8L3NwYW4+fFxufCYjeDA2MDE72aHZotmj2aTigKzigKx8PHNwYW4gc3R5bGU9XCJmb250LWZhbWlseTogQW1pcmlcIj4mI3gwNjAxO9mh2aLZo9mk4oCs4oCsPC9zcGFuPnxcbnwmI3gwNjAyO9mh2aJ8PHNwYW4gc3R5bGU9XCJmb250LWZhbWlseTogQW1pcmlcIj4mI3gwNjAyO9mh2aI8L3NwYW4+fFxufCYjeDA2MDM72aHZotmjfDxzcGFuIHN0eWxlPVwiZm9udC1mYW1pbHk6IEFtaXJpXCI+JiN4MDYwMzvZodmi2aPigKzigKzigKzigKw8L3NwYW4+fFxufCYjeDA2ZGQ72aHZotmj4oCs4oCsfDxzcGFuIHN0eWxlPVwiZm9udC1mYW1pbHk6IEFtaXJpXCI+JiN4MDZkZDvZodmi2aM8L3NwYW4+fFxuXG5cblxuXG5cblxuXG5cblxuXG5cblxuIiwiYmlkaSI6InJ0bCIsImxhbmciOiJhciJ9 http://tarobish.github.io/Jomhuria/#live?eyJ2YWx1ZSI6InxKb21odXJpYXw8c3BhbiBzdHlsZT1cImZvbnQtZmFtaWx5OiBBbWlyaVwiPkFtaXJpPC9zcGFuPnxcbnwtLXwtLXxcbnwg2aHZotmj2aR8PHNwYW4gc3R5bGU9XCJmb250LWZhbWlseTogQW1pcmlcIj7Zodmi2aPZpDwvc3Bhbj58XG58JiN4MDYwMDvZodmi2aPZpOKArOKArHw8c3BhbiBzdHlsZT1cImZvbnQtZmFtaWx5OiBBbWlyaVwiPiYjeDA2MDA72aHZotmj2aTigKzigKw8L3NwYW4+fFxufCYjeDA2MDE72aHZotmj2aTigKzigKx8PHNwYW4gc3R5bGU9XCJmb250LWZhbWlseTogQW1pcmlcIj4mI3gwNjAxO9mh2aLZo9mk4oCs4oCsPC9zcGFuPnxcbnwmI3gwNjAyO9mh2aJ8PHNwYW4gc3R5bGU9XCJmb250LWZhbWlseTogQW1pcmlcIj4mI3gwNjAyO9mh2aI8L3NwYW4+fFxufCYjeDA2MDM72aHZotmjfDxzcGFuIHN0eWxlPVwiZm9udC1mYW1pbHk6IEFtaXJpXCI+JiN4MDYwMzvZodmi2aPigKzigKzigKzigKw8L3NwYW4+fFxufCYjeDA2ZGQ72aHZotmj4oCs4oCsfDxzcGFuIHN0eWxlPVwiZm9udC1mYW1pbHk6IEFtaXJpXCI+JiN4MDZkZDvZodmi2aM8L3NwYW4+fFxuXG5cblxuXG5cblxuXG5cblxuXG5cblxuIiwiYmlkaSI6InJ0bCIsImxhbmciOiJhciJ9 https://cloud.githubusercontent.com/assets/393132/10007375/ed7a5ef0-60c4-11e5-8582-fbcb563ace6b.png I'll do my best, because I think this is hard to do for @Tarobish https://github.com/Tarobish; given the handwritten nature of the mentioned positioning rules.

— Reply to this email directly or view it on GitHub https://github.com/Tarobish/Jomhuria/issues/27#issuecomment-142132184.

graphicore commented 9 years ago

I reopen to wait for the OK of @khaledhosny

that's a pretty long test document

khaledhosny commented 9 years ago

Looks good to me, great job!

graphicore commented 9 years ago

Cool, thanks!

Tarobish / Jomhuria

Arabic subtending marks are broken #27