search

Tarobish / Jomhuria

http://tarobish.github.io/Jomhuria/
SIL Open Font License 1.1
22 stars 6 forks source link

Minor issues with TTF #3

Closed davelab6 closed 9 years ago

davelab6 commented 9 years ago

I reviewed the TTF and found these minor issues; ideally these should be solved 'upstream' in the source files + build system

Copyright (c) 2010-2013, Khaled Hosny <khaledhosny@eglug.org>.
Portions copyright (c) 2010, Sebastian Kosch <sebastian@aldusleaf.org>

This Font Software is licensed under the Open Font License, Version 1.1.

should be 

Copyright 2015 Mehdi Beigpour (www.k-b-studio.com|tarobish@gmail.com). Copyright 2015, Lasse Fister (lasse@graphicore.de). Copyright 2010-2015 Khaled Hosny (khaledhosny@eglug.org). 
      Copyright (c) 2010-2013, Khaled Hosny (<khaledhosny@eglug.org>)

This Font Software is licensed under the SIL Open Font License, Version 1.1.
This license is copied below, and is also available with a FAQ at:
http://scripts.sil.org/OFL


-----------------------------------------------------------
SIL OPEN FONT LICENSE Version 1.1 - 26 February 2007
-----------------------------------------------------------

PREAMBLE
The goals of the Open Font License (OFL) are to stimulate worldwide
development of collaborative font projects, to support the font creation
efforts of academic and linguistic communities, and to provide a free and
open framework in which fonts may be shared and improved in partnership
with others.

The OFL allows the licensed fonts to be used, studied, modified and
redistributed freely as long as they are not sold by themselves. The
fonts, including any derivative works, can be bundled, embedded, 
redistributed and/or sold with any software provided that any reserved
names are not used by derivative works. The fonts and derivatives,
however, cannot be released under any other type of license. The
requirement for fonts to remain under this license does not apply
to any document created using the fonts or their derivatives.

DEFINITIONS
"Font Software" refers to the set of files released by the Copyright
Holder(s) under this license and clearly marked as such. This may
include source files, build scripts and documentation.

"Reserved Font Name" refers to any names specified as such after the
copyright statement(s).

"Original Version" refers to the collection of Font Software components as
distributed by the Copyright Holder(s).

"Modified Version" refers to any derivative made by adding to, deleting,
or substituting -- in part or in whole -- any of the components of the
Original Version, by changing formats or by porting the Font Software to a
new environment.

"Author" refers to any designer, engineer, programmer, technical
writer or other person who contributed to the Font Software.

PERMISSION & CONDITIONS
Permission is hereby granted, free of charge, to any person obtaining
a copy of the Font Software, to use, study, copy, merge, embed, modify,
redistribute, and sell modified and unmodified copies of the Font
Software, subject to the following conditions:

1) Neither the Font Software nor any of its individual components,
in Original or Modified Versions, may be sold by itself.

2) Original or Modified Versions of the Font Software may be bundled,
redistributed and/or sold with any software, provided that each copy
contains the above copyright notice and this license. These can be
included either as stand-alone text files, human-readable headers or
in the appropriate machine-readable metadata fields within text or
binary files as long as those fields can be easily viewed by the user.

3) No Modified Version of the Font Software may use the Reserved Font
Name(s) unless explicit written permission is granted by the corresponding
Copyright Holder. This restriction only applies to the primary font name as
presented to the users.

4) The name(s) of the Copyright Holder(s) or the Author(s) of the Font
Software shall not be used to promote, endorse or advertise any
Modified Version, except to acknowledge the contribution(s) of the
Copyright Holder(s) and the Author(s) or with their explicit written
permission.

5) The Font Software, modified or unmodified, in part or in whole,
must be distributed entirely under this license, and must not be
distributed under any other license. The requirement for fonts to
remain under this license does not apply to any document created
using the Font Software.

TERMINATION
This license becomes null and void if any of the above conditions are
not met.

DISCLAIMER
THE FONT SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO ANY WARRANTIES OF
MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT
OF COPYRIGHT, PATENT, TRADEMARK, OR OTHER RIGHT. IN NO EVENT SHALL THE
COPYRIGHT HOLDER BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
INCLUDING ANY GENERAL, SPECIAL, INDIRECT, INCIDENTAL, OR CONSEQUENTIAL
DAMAGES, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
FROM, OUT OF THE USE OR INABILITY TO USE THE FONT SOFTWARE OR FROM
OTHER DEALINGS IN THE FONT SOFTWARE.

should be

This Font Software is licensed under the SIL Open Font License, Version 1.1. This license is copied below, and is also available with a FAQ at: http://scripts.sil.org/OFL
ymax                   3088                    
hhea.ascent            2300                    
OS/2.sTypoAscender     2300                    
OS/2.usWinAscent       3188                    
ymin                   -1575                   
hhea.descent           -1300                   
OS/2.sTypoDescender    -1300                   
OS/2.usWinDescent      1675

they should be

ymax                   3088                    
hhea.ascent            3088                    
OS/2.sTypoAscender     3088                    
OS/2.usWinAscent       3088                    
ymin                   -1575                   
hhea.descent           -1575                   
OS/2.sTypoDescender    -1575                   
OS/2.usWinDescent      1575
graphicore commented 9 years ago

I used "Kourosh" instead of "Mehdi"

I did not yet tackle the vertical metrics.

Here the ttx dump of <name>

<?xml version="1.0" encoding="utf-8"?>
<ttFont ttLibVersion="2.5">

  <name>
    <namerecord nameID="0" platformID="3" platEncID="1" langID="0x409">
      Copyright 2015 Korosh Beigpour (www.k-b-studio.com|tarobish@gmail.com). Copyright 2015, Lasse Fister (lasse@graphicore.de). Copyright 2010-2015 Khaled Hosny (khaledhosny@eglug.org).
    </namerecord>
    <namerecord nameID="1" platformID="3" platEncID="1" langID="0x409">
      Jomhuria
    </namerecord>
    <namerecord nameID="2" platformID="3" platEncID="1" langID="0x409">
      Regular
    </namerecord>
    <namerecord nameID="3" platformID="3" platEncID="1" langID="0x409">
      Sorts Mill Tools 2.1.0_alpha1 : Jomhuria : 2-6-2015
    </namerecord>
    <namerecord nameID="4" platformID="3" platEncID="1" langID="0x409">
      Jomhuria
    </namerecord>
    <namerecord nameID="5" platformID="3" platEncID="1" langID="0x409">
      Version 000.001
    </namerecord>
    <namerecord nameID="6" platformID="3" platEncID="1" langID="0x409">
      Jomhuria-Regular
    </namerecord>
    <namerecord nameID="9" platformID="3" platEncID="1" langID="0x409">
      Kourosh Beigpour, Lasse Fister
    </namerecord>
    <namerecord nameID="11" platformID="3" platEncID="1" langID="0x409">
      https://github.com/Tarobish/Jomhuria
    </namerecord>
    <namerecord nameID="12" platformID="3" platEncID="1" langID="0x409">
      https://github.com/Tarobish/Jomhuria
    </namerecord>
    <namerecord nameID="13" platformID="3" platEncID="1" langID="0x409">
      This Font Software is licensed under the SIL Open Font License, Version 1.1. This license is copied below, and is also available with a FAQ at: http://scripts.sil.org/OFL
    </namerecord>
    <namerecord nameID="14" platformID="3" platEncID="1" langID="0x409">
      http://scripts.sil.org/OFL
    </namerecord>
  </name>

</ttFont>
graphicore commented 9 years ago

I just removed the vendorID it was ./Jomhuria-Regular.O_S_2f_2.ttx: <achVendID value="BLQ "/>

graphicore commented 9 years ago

@davelab6 : I fixed the vertical metrics as suggested and committed.

It seems that the setting is to huge for most of the font i.e. the font appears pretty small with big line gaps. There are some glyphs pushing the extreme values much further than the font usually would have, like unicode 06DD, you can look it up here: https://github.com/Tarobish/Jomhuria/blob/master/generated/documents/jomhuria-table.pdf

I can also get some glyphs with the highest and lowest y values pretty fast and easy with python, if that is interesting.

davelab6 commented 9 years ago

https://github.com/Tarobish/Jomhuria/tree/master/generated needs updating

graphicore commented 9 years ago

For whatever reason, I did not push the changes I made regarding this issue last week. It's now all updated and the line-height issue is visible in the pdfs.