More small things - Githubissues

Tarobish / Jomhuria

http://tarobish.github.io/Jomhuria/

SIL Open Font License 1.1

22 stars 6 forks source link

More small things #41

Open davelab6 opened 8 years ago

davelab6 commented 8 years ago

[x] @davelab6 to do another QA check
[x] add description to the top of the project page
[x] regenerate ttfs without an intermediate OTF step to reduce filesize
[ ] perhaps remove some glyphs that are not used directly now, because of the decompositions
[x] reorganize directory tree to match Mirza and Katibeh
[x] Unify copyright notices

graphicore commented 8 years ago

regenerate ttfs without an intermediate OTF step to reduce filesize

and

perhaps remove some glyphs that are not used directly now, because of the decompositions

We don't do this here, only in Katibeh and Mirza. We also don't do the decompositions stuff. It's all Amiri heritage in here.

reorganize directory tree to match Mirza and Katibeh

It's a very different build process. What do you do dislike? Why do you think this is necessary? Is it about renaming dirs with uppercase first?

The Generated dir in Mirza/Katibeh has a bit of a bad semantic. I could move Jomhuria/generated to Jomhuria/Build and move Mirza/Generated/Documents to Mirza/Build/Documents There I could hammer a bit.

graphicore commented 8 years ago

The directory structure is now the same as in Mirza and Katibeh.

Jomhuria$ ls
AUTHORS.txt       Documents  html        Makefile  README.md  Tools
CONTRIBUTORS.txt  Fonts      index.html  OFL.txt   Sources    VERSION.txt

graphicore commented 8 years ago

perhaps remove some glyphs that are not used directly now, because of the decompositions

wontfix. We don't do decompositions here. The font has 171 kB

davelab6 commented 8 years ago

wontfix

Okay no worries, this was just copied from the other 2.

However, I've added a new task at the top, Unify copyright notices as there are still 2 places with the old notice, plus the binary files which about 8 hours ago were using the notice as is in the following:

https://github.com/Tarobish/Jomhuria/blob/gh-pages/Sources/jomhuria-latin.ufo/fontinfo.plist#L10

https://github.com/Tarobish/Jomhuria/blob/gh-pages/Sources/jomhuria.sfdir/font.props#L6

graphicore commented 8 years ago

Oh, should it be like this, also in the font:

Copyright 2015 The Jomhuria Project Authors (info: lasse@graphicore.de)

I'll have to change this for Katibeh and Mirza as well.

davelab6 commented 8 years ago

The 6 chars "info: " are not needed

On Thursday, 3 March 2016, Lasse Fister notifications@github.com wrote:

Oh, should it be like this, also in the font:

Copyright 2015 The Jomhuria Project Authors (info: lasse@graphicore.de javascript:_e(%7B%7D,'cvml','lasse@graphicore.de');)

I'll have to change this for Katibeh and Mirza as well.

— Reply to this email directly or view it on GitHub https://github.com/Tarobish/Jomhuria/issues/41#issuecomment-191871903.

Cheers Dave

graphicore commented 8 years ago

done