Tarobish / Jomhuria

http://tarobish.github.io/Jomhuria/
SIL Open Font License 1.1
22 stars 6 forks source link

Anchors its broken, in "Hah fina" #42

Closed Tarobish closed 8 years ago

Tarobish commented 8 years ago

http://tarobish.github.io/Jomhuria/#live?eyJ2YWx1ZSI6Itit2ZAg2K3ZjSIsImJpZGkiOiJydGwiLCJsYW5nIjoiYXIifQ==

bda4329e-df9c-11e5-92d8-22f3f77f4924

graphicore commented 8 years ago

the live testing link above gives me this:

selection_085

Looks like missing anchors.

Tarobish commented 8 years ago

Just added, please check it out

graphicore commented 8 years ago

No update received. Note that you must switch your local branch to gh-pages. The graphical Github client that you have should be able to do so. I don't know how to do it with sparkle share though; but, once switched Sparkleshare should work again. (You want to do this for Mirza and Katibeh as well, BTW)

Tarobish commented 8 years ago

Check it now plz

Tarobish commented 8 years ago

I think i did it with the Jomhuria but to be honest no idea about the rest :)

graphicore commented 8 years ago

Nah, you pushed to master, but we don't use master anymore.

Here are recent changes made by you: https://github.com/Tarobish/Jomhuria/tree/master

Here they should be (gh-pages) https://github.com/Tarobish/Jomhuria

@davelab6 troubles for Kourosh to switch branches may be a good reason to keep the master/gh-pages duplication (referring to #36)

Tarobish commented 8 years ago

I did it :) right?

graphicore commented 8 years ago

Hehe, yeah, that's ok, too. You'll have trouble to stay in sync so, if you don't rebase your master branch from time to time ;-)

Tarobish commented 8 years ago

I see :)

graphicore commented 8 years ago

Oh, in your merged PR #44 Is see messages like Merge remote-tracking branch 'origin/gh-pages'

That means something on you computer is syncing with gh-pages …

Tarobish commented 8 years ago

Is that bad or...?

graphicore commented 8 years ago

Rather good.

graphicore commented 8 years ago

This looks fine now, on the live testing page:

selection_087

Maybe you want to check in InDesign

Tarobish commented 8 years ago

Great! works here too