Tarobish / Jomhuria

http://tarobish.github.io/Jomhuria/
SIL Open Font License 1.1
23 stars 6 forks source link

The Anchors position its broken in the extension part #43

Open Tarobish opened 8 years ago

Tarobish commented 8 years ago

It works perfectly in live testing, this is something wrong with the Adobe. its broken in indesign 87ff772a-df9c-11e5-84b5-dc8c3de75e95 ![screen shot 2016-03-01 at 11 03 39 am] screen shot 2016-03-01 at 11 03 39 am

graphicore commented 8 years ago

Looks also like missing anchors. The live testing link would still help a lot, even if it works there. So I can check it out myself.

Tarobish commented 8 years ago

:)

http://tarobish.github.io/Jomhuria/#live?eyJ2YWx1ZSI6Itir2Y7YpyDZvtmQ2ZHbjCDbjNmR2ZDbjCIsImJpZGkiOiJydGwiLCJsYW5nIjoiYXIifQ==

graphicore commented 8 years ago

selection_086

This is the result from shaping the live testing input—just to proof my claim that it helps ;-)

`uni06CC.fina|uni0650|uni0651|uni0640.1|uni06CC.init|space|uni06CC.fina|uni0650|uni0651|uni0640.1|uni067E.init|space|uni0627.fina|uni064E|uni0640.1|uni062B.init

The pieces uni0640.1 are our Kashida, that we insert to stop glyph collisions. I believe we had the very same issue just recently in Mirza and Katibeh: https://github.com/Tarobish/Mirza/issues/92

I think the anchors in uni0640.1 are missing for Adobe, which got confused by us inserting the Kashida (Harfbuzz handles this by using the original glyphs for the anchors, that's why it works in the browsers.)

Please add anchors to uni0640.1

Tarobish commented 8 years ago

You are always right :) just added. i'll check it later :)

graphicore commented 8 years ago

please check.

Tarobish commented 8 years ago

Here is the problem, characters are using same anchors be cause of the keshideh. it works somewhere it doesn't somewhere else

screen shot 2016-03-01 at 7 24 25 pm

graphicore commented 8 years ago

It may be that this works better in Mirza and Katibeh because of the decomposition we do there. In your example, the three dots are part of the first glyph, and not base + mark. So we destroy the mark-to-mark relation in Adobe by inserting the kashida. :-/ That's a bummer. I'll have to think about this.

Tarobish commented 8 years ago

yeah, it works better in Mirza and katibeh. is there anyway to ignore marks from the Kesideh parts? In that case, it works they way it has to be

graphicore commented 8 years ago

is there anyway to ignore marks

I don't know what you mean. They are there, so they must go somewhere.

In that case, it works they way it has to be

I don't get it :-)

Tarobish commented 8 years ago

I know :) i mean generating marks from the right characters instead of keshideh The problem is, the marks right now are generating from the keshideh part not from the characters thats why the position its wrong

graphicore commented 8 years ago

Yeah. That's what Adobe does different than Harfbuzz. When we insert that Kashideh, the shaping engine must decide where the marks belong. For us, Harfbuzz decides right and Adobe decides wrong.

Tarobish commented 8 years ago

Got it :)

davelab6 commented 8 years ago

https://github.com/googlefonts/gf-docs/blob/master/ProjectChecklist.md#adobe-creative-suite

graphicore commented 8 years ago

@davelab6 Yeah I can report it. It's interesting though how it was possible to work around it in Mirza/Katibeh, but how it is hard here.

davelab6 commented 8 years ago

https://github.com/twardoch/ttfdiet/ also full of 'no' for CC

graphicore commented 8 years ago

It's interesting that we don't have bigger problems with Adobe CC in Mirza/Katibeh, because we really do a lot of decomposition. But it's mostly done in init/medi/fina, maybe that's the silver bullet.