Tarobish / Jomhuria

http://tarobish.github.io/Jomhuria/
SIL Open Font License 1.1
22 stars 6 forks source link

features left from Amiri #9

Closed Tarobish closed 9 years ago

Tarobish commented 9 years ago

features left from Amiri (I'v seen this some others palaces in our text samples. in Arabic uni062A.inti has a vertical dots, but it seem it is feature lefts from Amiri screen shot 2015-06-06 at 10 48 28 am

graphicore commented 9 years ago

I can't find the same word anymore. The positions changed a lot because of the changed line-height. However, there was a lot of instances in the document.

I removed the rule at the bottom of this post. Note the

   script arab;
   language ARA;

Part, this means this should not be active for Farsi. Should we keep it and try if the words render correct when we set the right language? Or don't we need it at all?

feature calt {
   lookupflag IgnoreMarks;
   script arab;
   language ARA;

   // Replace teh init following teh/theh medi by a teh init with two vertical
   // dots.
   sub uni062A.init'
       [uni062A.medi uni062B.medi]
   by uni067A.init;

   sub uni062A.init_High'
       [uni062A.medi_High uni062B.medi_High]
    by uni067A.init_High;
} calt;
Tarobish commented 9 years ago

On Jun 19, 2015, at 1:05 PM, Lasse Fister notifications@github.com wrote:

I can't find the same word anymore. The positions changed a lot because of the changed line-height. However, there was a lot of instances in the document.

I removed the rule at the bottom of this post. Note the

script arab; language ARA; Part, this means this should not be active for Farsi. Should we keep it and try to if the words render correct when we set the right language? Or don't we need it at all?

feature calt { lookupflag IgnoreMarks; script arab; language ARA; I didn’t find any problem in Farsi i think we can keep it

// Replace teh init following teh/theh medi by a teh init with two vertical // dots. sub uni062A.init' [uni062A.medi uni062B.medi] by uni067A.init;

sub uni062A.init_High' [uni062A.medi_High uni062B.medi_High] by uni067A.init_High; } calt; — Reply to this email directly or view it on GitHub https://github.com/Tarobish/Jomhuria/issues/9#issuecomment-113628505.

graphicore commented 9 years ago

I didn’t find any problem in Farsi But is the "vertical dots" thing something useful in Arabic?

Tarobish commented 9 years ago

On Jun 20, 2015, at 11:28 AM, Lasse Fister notifications@github.com wrote:

I didn’t find any problem in Farsi But is the "vertical dots" thing something useful in Arabic?

No, there is no Vertical dots in Arabic. we don’t need that.

— Reply to this email directly or view it on GitHub https://github.com/Tarobish/Jomhuria/issues/9#issuecomment-113800768.

graphicore commented 9 years ago

Ok, great. I'm closing this.

khaledhosny commented 9 years ago

For the record, this feature in Amiri is used to avoid colliding the dots of these glyph as the dots are wider than the base glyphs here, but as this is not an issue with your font it can go. Using vertical dots to solve this kind of collision is rather common in traditional Arabic styles (where it is likely to happen), but even modern, simplified designs with always-vertical dots are not unseen.

graphicore commented 9 years ago

Yeah, I thought so. We have solved it differently though.