Tarobish / Katibeh

Katibeh Arabic Font Project
http://tarobish.github.io/Katibeh/
SIL Open Font License 1.1
13 stars 4 forks source link

Ignore Kerning #80

Closed Tarobish closed 8 years ago

Tarobish commented 8 years ago

uniFE8E uniFE82 uniFE8E.short + "uni066E0649" if AlefFina has mark's below "uni066E06BA" if AlefFina has mark's below


uni0627 uni0627.short + "uni066E0649" if AlefFina has mark's below "uni066E06BA" if AlefFina has mark's below "uni066E0631" if AlefFina has mark's below


uniFD0E uniFD2A uni066E0631 uni066E0631.fina uniFD0F uniFD2B uniFEAE uni0631 uni0694.fina uni0694 uni0693.fina uni0693 uni0692.fina uni0692 uniFB8D uni0691 uniFEB0 uni0632 uni06EF.fina uni06EF uni0699.fina uni0699 uniFB8B uni0698 uni0697.fina uni0697 uni0696.fina uni0696 uni0695.fina uniFC5C uni0771.fina uni0771 uni076C.fina uni076C uni076B.fina uni076B uni075B.fina uni075B + "uni0627" and "uni0627.short" if AlefIso has mark's below

graphicore commented 8 years ago

Why would you kern these in the first place? I'm just using the kerning data as provided by you. "Ignore these" is hard, if possible (with a reasonable amount of work) at all after they have been kerned.

graphicore commented 8 years ago

Well, there is a " ignore position (, )*;" keyword, so it is possible, however, I need to inject this into the kernFeatureGenerator at the right occasion. That kind of sucks, ufo-kerning is not made for this kind of thing :-(

Tarobish commented 8 years ago

Here is the Problem please check the picture, "Adobe Arabic” compare to “Katibeh” Normally “reh-Alef” it has to be kern like the one in the left side but when “Alef” has marks below it would be colliding they solved this problem by moving marks below “Reh” when they are neighbor “Alef” with the marks below has a different spacing when its alone

On Feb 4, 2016, at 11:08 AM, Lasse Fister notifications@github.com wrote:

Well, there is a " ignore position (, )*;" keyword, so it is possible, however, I need to inject this into the kernFeatureGenerator at the right occasion. That kind of sucks, ufo-kerning is not made for this kind of thing :-(

— Reply to this email directly or view it on GitHub https://github.com/Tarobish/Katibeh/issues/80#issuecomment-180005021.

graphicore commented 8 years ago

pic is missing

graphicore commented 8 years ago

Maybe you can't send the images as attachment of a mail reply.

Tarobish commented 8 years ago

4d72eca4-cb42-11e5-93cd-57d6bf7092b9 4fc3eb3e-cb42-11e5-92ce-5d1bacf49859

Tarobish commented 8 years ago

Maybe its better to do the same :)

graphicore commented 8 years ago

Maybe its better to do the same :)

What do you mean? What is "the same"?

Tarobish commented 8 years ago

Like the Adobe Arabic, moving marks to the bottom Please compare the position of marks "Alef" with marks below, after "Reh" compare to the "Alef" which is alone

996e86f0-cb73-11e5-86e0-9a404755d96e

graphicore commented 8 years ago

Yeah, I like that. I will try it. It's at this point probably better than ignoring the kerning, because I can apply it after the original kerning, so I don't have to mess around with your kerning data. Also, it may look better.

Tarobish commented 8 years ago

Awesome :)

graphicore commented 8 years ago

I made some testing tables to check what we are talking about:

http://tarobish.github.io/Katibeh/html/generated-pages.html#testsKern/Issue%20%2380.01%3A%20colliding%20bottom%20marks

http://tarobish.github.io/Katibeh/html/generated-pages.html#testsKern/Issue%20%2380.02%3A%20colliding%20bottom%20marks

http://tarobish.github.io/Katibeh/html/generated-pages.html#testsKern/Issue%20%2380.03%3A%20colliding%20bottom%20marks

The third one 80.03 is the worst, the others are not so bad actually.

Tarobish commented 8 years ago

it seems some ligatures and connection did not generated in the table. would please check them out like uniFD0E, uniFD2A it you could that would be great . then ill let you know which characters are usable to fix them and get rid of the rest

Tarobish commented 8 years ago

Based on the generated test pages we are fine from issues #80.01 and #80.02 lets fix #80.03 but please generate them all :) thanks

graphicore commented 8 years ago

seems some ligatures and connection did not generated in the table. would please check them out like uniFD0E, uniFD2A it you could that would be great . then ill let you know which characters are usable to fix them and get rid of the rest

The first two lines in 80.03 are FD0E the third and the fourth line are uniFD2A

selection_070

Tarobish commented 8 years ago

You are right but it dint general them all like شر or سر or شز or سژ actually we don’t have these ligature with Persian and Arabic's form here! and they are the most that we want

On Feb 11, 2016, at 11:22 AM, Lasse Fister notifications@github.com wrote:

seems some ligatures and connection did not generated in the table. would please check them out like uniFD0E, uniFD2A it you could that would be great . then ill let you know which characters are usable to fix them and get rid of the rest

The first two lines in 80.03 are FD0E the third and the fourth line are uniFD2A

https://cloud.githubusercontent.com/assets/393132/12987604/16d7fe94-d0fd-11e5-9a86-37f1c504a30a.png — Reply to this email directly or view it on GitHub https://github.com/Tarobish/Katibeh/issues/80#issuecomment-183020063.

graphicore commented 8 years ago

I can add these for you and remove the others?

Tarobish commented 8 years ago

Please! do you want me to write them all?

On Feb 11, 2016, at 11:51 AM, Lasse Fister notifications@github.com wrote:

I can add these for you and remove the others?

— Reply to this email directly or view it on GitHub https://github.com/Tarobish/Katibeh/issues/80#issuecomment-183035198.

graphicore commented 8 years ago

how many are there?

Tarobish commented 8 years ago

in like 20 or 30

On Feb 11, 2016, at 11:55 AM, Lasse Fister notifications@github.com wrote:

how many are there?

— Reply to this email directly or view it on GitHub https://github.com/Tarobish/Katibeh/issues/80#issuecomment-183036263.

graphicore commented 8 years ago

actually I think only the variation in the second part matters. Plus if there are any marks below that can be added.

Tarobish commented 8 years ago

ok, please lets try these i think we will be fine را - زا - ژا سرا - سزا - سژا - شرا - شزا - شژا صرا - صزا - صژا - ضرا - ضزا - ضژا برا - ترا - ثرا - پرا - یرا بزا - تزا - ثزا - پزا - یزا بژا - تژا - ثژا - پژا - یژا also these character when the ligature or characters are in meddle form like ببرا (last three characters) or بصرا (last three) the rest doesn't matter

graphicore commented 8 years ago

I'll do

Tarobish commented 8 years ago

Great!

graphicore commented 8 years ago

It's all added at the top of the 80.03 table

Tarobish commented 8 years ago

Thanks

Tarobish commented 8 years ago

screen shot 2016-02-11 at 12 46 54 pm screen shot 2016-02-11 at 12 46 41 pm screen shot 2016-02-11 at 12 46 13 pm screen shot 2016-02-11 at 12 46 49 pm screen shot 2016-02-11 at 12 45 54 pm screen shot 2016-02-11 at 12 46 07 pm screen shot 2016-02-11 at 12 46 20 pm screen shot 2016-02-11 at 12 46 00 pm screen shot 2016-02-11 at 12 46 27 pm screen shot 2016-02-11 at 12 45 46 pm

There you go :)

graphicore commented 8 years ago

The red dots are the cases that must work and the rest are "fantasy combinations" or at least very uncommon?

Tarobish commented 8 years ago

Yes, the res dots are the case the rest "fantasy combinations" and very uncommon in many cases :)))

Tarobish commented 8 years ago

the point is vowels are really common in the Arabic, but in arabic language we just have these character ر - ز - س - ش - ص - ض also sometimes in Persian which has them all plus ژ

davelab6 commented 8 years ago

(No, github won't place images into issue comments that come in as mail attachements)

khaledhosny commented 8 years ago

Off-topic, but that “serif” at end of ر is pretty weird, and not so good looking IMHO.

graphicore commented 8 years ago

@Tarobish Check it out. All your requested cases work now.