search

Tarobish / Katibeh

Katibeh Arabic Font Project
http://tarobish.github.io/Katibeh/
SIL Open Font License 1.1
12 stars 4 forks source link

jeem-ar.medi #82

Closed Tarobish closed 8 years ago

Tarobish commented 8 years ago

Dot's position its broken in "jeem-ar.medi" either in ligature or character positioning screen shot 2016-02-03 at 7 04 50 pm

screen shot 2016-02-03 at 7 05 48 pm

graphicore commented 8 years ago

What should happen where? I think I've seen this fail somewhere in http://tarobish.github.io/Katibeh/html/generated-pages.html as well. May need some investigation.

graphicore commented 8 years ago

I think there is something wrong with the anchors. In the first image, if you don't like it like that it may be the anchor position. Or does it use the wrong anchor, then I have to decompose it differently.

In the second image it is similar: either the anchor is missing (you must solve that) or the decomposition uses a wrong mark for a non-existing anchor.

Can you please explain what you expect to see here and provide a live testing document.

Tarobish commented 8 years ago

It has to be something wrong with the decomposing. these two ligatures are using the same base and anchors, in the right one, dots position its wrong but the left one it works perfectly. same problem with the characters without ligatures. "jeem-ar.medi" its broken but "tcheh-ar.medi" its not and "jeem-ar.fina" it works but "tcheh-ar.fina" doesn't.

screen shot 2016-02-08 at 9 53 06 am

screen shot 2016-02-08 at 9 58 57 am

screen shot 2016-02-08 at 9 52 46 am screen shot 2016-02-08 at 9 52 30 am screen shot 2016-02-08 at 10 02 27 am They have to be like these

screen shot 2016-02-08 at 8 18 00 am

screen shot 2016-02-08 at 8 17 48 am

graphicore commented 8 years ago

Ok, I think the solution here is pretty straight forward:

We need xxx.center marks for all marks that go to the center in the fina glyphs of the HAH-as-Base family of glyphs.

And for the init and medi versions of uni062D (one dot in the center) I made the wrong decomposition to dotcenterar where just the dot below should have been used.

I'll post a list of missing xxx.center in a few minutes.

Tarobish commented 8 years ago

Thanks :)

graphicore commented 8 years ago

Ok, cool:

selection_060

All needed marks were already in the font. But some ligatures are missing center anchors. You must do this:

uni066E062D

uniFC40

A bit offtopic but for uni0696.fina some other ligatures also need a center anchor:

uni066E0631

uni066E0631.fina

uniFD0E

uniFD2A

uniFD0F

uniFD2B

Tarobish commented 8 years ago

Just perfect

graphicore commented 8 years ago

@Tarobish will you repair the ligatures?

Tarobish commented 8 years ago

I'm on it

Tarobish commented 8 years ago

For uni066E062D, the center anchor its right there but seems its not functioning as well as uniFC40, screen shot 2016-02-09 at 3 58 02 pm

screen shot 2016-02-09 at 4 03 49 pm

uni066E0631, uni066E0631.fina, uniFD0E, uniFD0F and uniFD2B are looks good to me. didn't find anything, if we move ranchers a bit then it would be colliding in the small point sizes.

graphicore commented 8 years ago

uni066E0631, uni066E0631.fina, uniFD0E, uniFD0F and uniFD2B are looks good to me. didn't find anything, if we move ranchers a bit then it would be colliding in the small point sizes.

In all tables it's just one column, where the second glyph is uni0696.fina:

selection_064

See how the dot is at the top left? It's supposed to be more in the center, just as in uni0696.fina That kind of displacement happens when there is no anchor to attach to.

graphicore commented 8 years ago

Oh, and it needs a center anchor there.

Tarobish commented 8 years ago

Done :) both mirza and katibeh

graphicore commented 8 years ago

For uni066E062D, the center anchor its right there but seems its not functioning as well as uniFC40,

Ok, I have a theory, please read carefully and pay attention:

For ligatures, we do mark2ligature attachment. There the computer must decide to which anchor of the ligature a mark belongs. I don't know how glyphs decides this. However, in the ufo I can see this:

selection_065

Note that there are two anchors for top: top_1 and top_2 and two for the bottom: bottom_1 and bottom_2 Then there is just one center anchor. Also there is carret_1 which is the position where the cursor will be located within the ligature. 1 carret means the ligature is made of 2 parts, 2 carrets means the ligature is made out of 3 parts, and so on.

Within Glyphs, what are the names of the top and bottom anchors?

If it is like the first option, we need either two center anchors. Maybe left and right of the carret.

If it is like the second option, what we need is center_2 and Maybe also center_1

I think the best implementation would be if just center_2 is enough. So please rename these anchors to center_2

Tarobish commented 8 years ago

Also it been added to uniFD2A, uniFD0E, uniFD2B and uniFD0F

graphicore commented 8 years ago

probably, for all the ligatures where you just added it, we need to solve the anchor issue as well. Let's try to find the solution for uniFC40 first, so we can iterate faster.

Tarobish commented 8 years ago

its all top_1 top_2 bottom_1 bottom_2 and center_1 screen shot 2016-02-09 at 5 00 27 pm

graphicore commented 8 years ago

:+1:

So we want center_2

Tarobish commented 8 years ago

plz check it

graphicore commented 8 years ago

I filed a bug report in the Glyphs Forum https://forum.glyphsapp.com/t/problems-getting-custom-ligature-anchors-to-work/3846

graphicore commented 8 years ago

Ok, Looks allright now!

selection_068