search

Tarrasch / zsh-autoenv

Autoenv for zsh
700 stars 30 forks source link

Improvements #4

Closed blueyed closed 10 years ago

blueyed commented 10 years ago

Various improvements, see #3 for discussion.

Tarrasch commented 10 years ago

Wow! This looks totally amazing! Thank you! I would like to merge this, and then you can look at my comments and make a commit that fixes the small issues I found. Does this sound ok?

I'll add you as a collaborator so you can merge for yourself too. Though I still think we should keep a review process for future PRs. :)

Tarrasch commented 10 years ago

Btw, what does TBD? To Be Decided?

blueyed commented 10 years ago

Wow! This looks totally amazing! Thank you!

Thanks, you're welcome.

I would like to merge this, and then you can look at my comments and make a commit that fixes the small issues I found. Does this sound ok?

I'll integrate your comments, and then you can merge it.

TBD means "to be discussed" (at least that's what I've meant).

blueyed commented 10 years ago

I'll create a PR for the varstash branch later. I would like to let this sink a bit / experiment with it a bit more.

blueyed commented 10 years ago

I'll add you as a collaborator so you can merge for yourself too.

Cool, thanks!

Though I still think we should keep a review process for future PRs. :)

Indeed. It would be nice if we would never merge our own commits, at least if they are bigger, like this one.