search

Tarrasch / zsh-autoenv

Autoenv for zsh
694 stars 30 forks source link

Use AUTOENV_ prefix for variables #6

Closed blueyed closed 9 years ago

blueyed commented 9 years ago

What's the name of the project?

While going wild on the source, I've used the "dotenv" name for vars etc, because it was used internally already.

Should this get refactored to use AUTOENV_* vars? This would be nice to have it as a drop-in replacement for https://github.com/kennethreitz/autoenv - as long as it uses the same mechanism for AUTOENV_ENV_FILENAME etc.

Tarrasch commented 9 years ago

I think that's a great idea. I took the "dotenv" namespace from Joshua's implementation, but I much rather conform to whatever kennethreitz/autoenv uses instead. Would you like to send a PR for this? :)

blueyed commented 9 years ago

Would you like to send a PR for this? :)

Sure, but I would build it on top of the "improvements" and/or "varstash" branch/PR. It would be great to get feedback on those from you.

Tarrasch commented 9 years ago

Ah, I'm reviewing it now. :)

blueyed commented 9 years ago

I'll look into this when the varstash branch has been merged, in a few days probably.

Tarrasch commented 9 years ago

Makes sense. :)

blueyed commented 9 years ago

Merged into master.