search

Tarrasch / zsh-autoenv

Autoenv for zsh
694 stars 30 forks source link

Next: varstash integration, tests refactoring, s/dotenv/autoenv/ #8

Closed blueyed closed 9 years ago

blueyed commented 9 years ago

Please review it.

I'm likely to amend/rebase it tomorrow anyway, but any feedback is appreciated!

Tarrasch commented 9 years ago

Ah, sorry, was on my graduation ceremony during the weekend! I usually am faster to reply. I'll try to review this by the end of the day. :)

blueyed commented 9 years ago

I did a bunch more stuff today, adding support for autoenv_source_parent, which allows to source / load parent env files.

Tarrasch commented 9 years ago

Just went through all comments. Wow! You're a champion! Thank you, just go through my comments and see if they apply and adjust your code accordingly, then I think we're fine to merge. :)

Also, some more docs describing the new cool features would be nice. :)

blueyed commented 9 years ago

I've pushed two new commits.

It should be fine then to get merged. I do not think rebasing / cleaning up the commits is necessary, do you?

Would you like to start writing docs, after this is merged? I could review them then, and I think it's good to have someone else write them initially to see if there's common sense.

Tarrasch commented 9 years ago

Cool, I have no comments on the commits, they look good.

Yea, no need to rebase, we don't need super-clean history for this project. :)

I can take a stab at writing the docs, I'm a bit uncertain of what the varstash parts does. But I'll try.

blueyed commented 9 years ago

I can take a stab at writing the docs, I'm a bit uncertain of what the varstash parts does. But I'll try.

:+1:

You should see it's basic usage in the tests.