Closed blueyed closed 9 years ago
Ah, sorry, was on my graduation ceremony during the weekend! I usually am faster to reply. I'll try to review this by the end of the day. :)
I did a bunch more stuff today, adding support for autoenv_source_parent
, which allows to source / load parent env files.
Just went through all comments. Wow! You're a champion! Thank you, just go through my comments and see if they apply and adjust your code accordingly, then I think we're fine to merge. :)
Also, some more docs describing the new cool features would be nice. :)
I've pushed two new commits.
It should be fine then to get merged. I do not think rebasing / cleaning up the commits is necessary, do you?
Would you like to start writing docs, after this is merged? I could review them then, and I think it's good to have someone else write them initially to see if there's common sense.
Cool, I have no comments on the commits, they look good.
Yea, no need to rebase, we don't need super-clean history for this project. :)
I can take a stab at writing the docs, I'm a bit uncertain of what the varstash parts does. But I'll try.
I can take a stab at writing the docs, I'm a bit uncertain of what the varstash parts does. But I'll try.
:+1:
You should see it's basic usage in the tests.
Please review it.
I'm likely to amend/rebase it tomorrow anyway, but any feedback is appreciated!