search

Tarskin / HappyTools

A tool for the (high-throughput) processing of HPLC data.
Apache License 2.0
34 stars 16 forks source link

NotImplementedError when saving Calibrants #48

Open wulfbear opened 4 years ago

wulfbear commented 4 years ago

Describe the bug Saving of calibrants after Peak Detection in Example File is not working. Return text in py console: Exception in Tkinter callback Traceback (most recent call last): File "C:\Users\kaihi\AppData\Local\Programs\Python\Python37\lib\tkinter\__init__.py", line 1705, in __call__ return self.func(*args) File "C:\Users\kaihi\Desktop\HappyTools-master\HappyTools.py", line 388, in save_calibrants save_calibrants(self) File "C:\Users\kaihi\Desktop\HappyTools-master\HappyTools\util\functions.py", line 42, in save_calibrants raise NotImplementedError('This feature is not implemented in the ' + NotImplementedError: This feature is not implemented in the refactor yet.

To Reproduce Steps to reproduce the behavior:

  1. Go to 'File\OpenChromatogram\IgG Vtag 1_ACQUITY FLR ChA...'
  2. Perform Smoothing and Baseline Correction as in Tutorial.
  3. Click on 'Advanced\Peak Identification'
  4. See peaks being identified.
  5. Click on 'Advanced\SaveCalibrant'
  6. See error in console.

Expected behavior A clear and concise description of what you expected to happen.

Screenshots image

Desktop (please complete the following information):

Tarskin commented 4 years ago

This is my failure, this feature still needs to be re-designed as I wasn't too happy with the old implementation of it.