search

Tarsnap / kivaloo

Kivaloo is a collection of utilities which together form a data store associating keys of up to 255 bytes with values of up to 255 bytes.
http://www.tarsnap.com/kivaloo.html
Other
201 stars 17 forks source link

Fix netbuf nitpicks #254

Closed gperciva closed 3 years ago

gperciva commented 3 years ago

I'd normally make this change in libcperciva first, but since the mistake in a617893 occurred in this repository, I figured I should fix it here.

The coverity-scan for kivaloo shows that this resolves the warning, although there's a bunch of other warnings. The coverity-scan for libcperciva would be a better test, but I can't trigger that again until midnight GMT.

It's probably worth waiting until then, because I've messed up this fix once already, but I figured that I should get it up now so that you can glance at it this afternoon.

gperciva commented 3 years ago

I imported these into libcperciva's coverity-scan https://github.com/Tarsnap/libcperciva/tree/coverity-scan and coverity reports 0 problems with libcperciva.

So I'm confident that this PR (in kivaloo) is ready for merging; then I'll import it to libcperciva for real.