Nitpick for static analyzers. Currently we're calling kvldskey_create() on uninitialized buffers, and then initializing the buffer afterwards. Copying uninitialized bytes around smells fishy.
This does a memset() before kvlds_create().
I don't see any impact on performance using a smaller version of the local benchmark suite:
Looks like statistical noise to me. I ran the benchmark 11 times (discarding the first run); here's some sample output from one time:
Nitpick for static analyzers. Currently we're calling
kvldskey_create()
on uninitialized buffers, and then initializing the buffer afterwards. Copying uninitialized bytes around smells fishy.This does a
memset()
beforekvlds_create()
.I don't see any impact on performance using a smaller version of the local benchmark suite:
Looks like statistical noise to me. I ran the benchmark 11 times (discarding the first run); here's some sample output from one time: