Closed gperciva closed 1 year ago
LGTM aside from one missing change.
Fixed, plus a few other inconsistencies: sometimes I added "unexpanded" in the API comment text; other places, I only changed the ${key_unexpanded}
variable.
I went with adding it to the API comment text, so there's 3 additions of _unexpanded
in each. For example,
* crypto_aes_key_expand_arm(key_unexpanded, len): * Expand the ${len}-byte unexpanded AES key ${key_unexpanded} into a
LGTM, please rebase.
Rebased, ready for merge.
Previously, we used
${key}
to refer both to the unexpanded and expanded AES keys. For example,This seemed sub-optimal.
(That said, if there's a strong tradition of using the same variable name in the cryptographic community, of course we shouldn't rename these. It's true that although we've reused the name, the type of variable differs --
uint8_t *
vs.struct crypto_aes_key
.)I have a separate branch which renamed the relevant
${key}
to${key_expanded}
instead, but that was a bigger patch.