Tarsnap / libcperciva

BSD-licensed C99/POSIX library code shared between tarsnap, scrypt, kivaloo, spiped, and bsdiff.
Other
112 stars 11 forks source link

apisupport: detect if we need `-Wno-deprecated-declarations` for AES #516

Closed gperciva closed 7 months ago

gperciva commented 8 months ago

OpenSSL 3.0 marked the low-level AES functions as deprecated, and warned that they might be removed completely in the future.

I think it makes sense to use those functions for as long as possible. If/when we ship our own software implementation, if a security flaw was detected in it, we'd have to make a new release ASAP. By contrast, if we're using the openssl version, then users only need to update their libssl packages from their operating system.

As such, compiler warnings about deprecations when compiling crypto_aes.c aren't useful; we know very well that we're using those functions.