search

Tarsnap / libcperciva

BSD-licensed C99/POSIX library code shared between tarsnap, scrypt, kivaloo, spiped, and bsdiff.
Other
112 stars 11 forks source link

Style: fix whitespace #522

Closed gperciva closed 3 months ago

gperciva commented 3 months ago

This replaces #521.

I think it's been 6-12 months since I last tried to get 3rd-party PRs to allow us to "approve" the github action run, so it's time to try again.

cperciva commented 3 months ago

Needs a "reported by" tag in the commit message. (Ok @TimWolla only reported one of the three, but it's a matter of principle.)

gperciva commented 3 months ago

Done.

cperciva commented 3 months ago

@TimWolla Should this be Reported by: Tim Wolla or Reported by: Tim Düsterhus?

gperciva commented 3 months ago

We already have Tim D in the repo as the author of 28dfe297b66e25fd708031613590f5291cb06e9d, so it makes sense to use that name for the "Reported by".

Commit message amended.

TimWolla commented 3 months ago

Should this be Reported by: Tim Wolla or Reported by: Tim Düsterhus?

As Graham correctly determined, “Tim Düsterhus”.

TimWolla commented 3 months ago

I think it's been 6-12 months since I last tried to get 3rd-party PRs to allow us to "approve" the github action run, so it's time to try again.

You would need the pull_request workflow trigger in the workflow definition for it to run on pull requests from forks.