Fix network_connect_bind() comment; sa_b can be NULL

Tarsnap / spiped

Spiped is a utility for creating symmetrically encrypted and authenticated pipes between socket addresses.

http://www.tarsnap.com/spiped.html

Other

858 stars 56 forks source link

Fix network_connect_bind() comment; sa_b can be NULL #355

Closed gperciva closed 2 years ago

gperciva commented 2 years ago

Sorry, I just noticed this when re-reviewing #353. The API comment for network_connect_bind() doesn't mention anything about what might happen if sa_b is NULL.

gperciva commented 2 years ago

Rebased with an alternate wording.

cperciva commented 2 years ago

Better, but what do you think of s/then// everywhere? What you have is grammatical (if ... then ...) but ambiguous, since "then" could be interpreted as meaning "after completing the previous steps", and I think it's clear without that word.

gperciva commented 2 years ago

Ok. Revised the PR, and also clarified the commit message.