search

Tarsnap / tarsnap

Command-line client code for Tarsnap.
https://tarsnap.com
Other
871 stars 60 forks source link

fedora packaging - removed lzma-devel dependency #481

Closed adamthiede closed 3 years ago

adamthiede commented 3 years ago

lzma-devel is no longer in Fedora and the tarsnap package builds just fine without it.

gperciva commented 3 years ago

Thanks for the PR, @elagost!

I think this ok, but please change the message to "lzma-devel dependency removed as it was replaced by xz-devel".

I would normally want to indicate this by using a boolean expression in the spec file, i.e.

BuildRequires:   (xz-devel or lzma-devel)

but apparanently that capability was only added in rpm 4.13 [1]. CentOS 7 uses rpm 4.11.3, so we can't rely on that. :(

[1] https://rpm.org/user_doc/boolean_dependencies.html

I've checked that this works with centos 7 (originally 2014-07-07, which is the oldest currently-supported version of that distro; centos 6 was EOL on 2020-11-30). RHEL 6 is not supported any more; RHEL 7 is similar to CentOS, so it should be fine. The oldest currently-supported version of fedora is 32 (2020-04-08), so I'm sure it also has xz-devel.

gperciva commented 3 years ago

Oh, one more piece of reassurance about RHEL: version 6 (which is EOL'd) already supports xz-devel: https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/6/html/package_manifest/chap-base-server-variant so there's absolutely no doubt in my mind about RHEL 7+.

adamthiede commented 3 years ago

Updated the wording as you mentioned. Hope that fits right. Thanks for replying so quickly! You rock.

gperciva commented 3 years ago

Thanks for the update! Are you familiar with git rebase? If not, don't worry; we can do that when we merge the PR. If you are familiar with it, please rebase the two commits together and do a force-push to your branch.

adamthiede commented 3 years ago

Not too familiar, but I believe what I've done works. Please correct me if I'm wrong.

gperciva commented 3 years ago

Looks great! Now I just need to figure out how to get the actions to run.

(and no, I'm not seeing the "Approve and run" box that's mentioned in https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks)

cperciva commented 3 years ago

Ok, this looks fine to me, but github won't let me merge it until checks are completed and they're not running... @gperciva can you figure this out?

gperciva commented 3 years ago

No, apparently I can't figure it out. :(

I've disabled the "require status checks" temporarily, so you should be able to merge it now. I'll revisit the question of "approving status checks for first-time contributers" later. (This is a recent change in github, so it's possible that there's still some bugs in the infrastructure.)