TartanLlama / expected

C++11/14/17 std::expected with functional-style extensions
https://tl.tartanllama.xyz
Creative Commons Zero v1.0 Universal
1.55k stars 135 forks source link

Update Catch2 version to fix compilation error with glibc greater than 2.33 #116

Closed SeedyROM closed 1 year ago

SeedyROM commented 2 years ago

Bump Catch2 version from v2.9.2 to v2.13.5 to fix MINSIGSTKSZ not being used as a constant expression (see #114).

GabrielRavier commented 2 years ago

LGTM, can confirm this fixes compilation for me too.

daira commented 2 years ago

LGTM. I had to include this in #117 in order to build.

daira commented 1 year ago

This was fixed in b74fecd4448a1a5549402d17ddc51e39faa5020c (with a later Catch2 version), so the PR can be closed.