search

TartanLlama / secret-hitler-strategies

Unofficial Secret Hitler strategy guide
https://secrethitler.tartanllama.xyz
Other
33 stars 6 forks source link

Add image above each section #52

Closed TartanLlama closed 7 years ago

TartanLlama commented 7 years ago

Have a look and see what you folks think. Open to other suggestions for how to break up the text some more.

davidtwco commented 7 years ago

I like it, but it doesn't work great on the final few sections where there isn't much content - the image is visible multiple times in the viewport.

davidtwco commented 7 years ago

Perhaps inclusion of annotated images of the deck, or of a table with players around it could help illustrate points?

TartanLlama commented 7 years ago

Yeah, I agree about the final few sections. Maybe if we merged the contributors section with the license and attribution section it'd look better.

Good idea on the deck and table. Not sure what the best way to create the table image would be.

davidtwco commented 7 years ago

I'll take a shot at working one together in the style of the other artwork.

TartanLlama commented 7 years ago

Oh wow, adding the title image works really well.

davidtwco commented 7 years ago

I think the font next to the title image should change, the Secret Hitler website uses a mix of the rounded font that we use throughout and another non-rounded font for some of the larger headings like "FAQ". I don't think the rounded font looks great at that size.

TartanLlama commented 7 years ago

Unfortunately the other font they use isn't free. I make the title uppercase which looks a bit better.

TartanLlama commented 7 years ago

Some pretty suspect Javascript to split up the page and add a gun image, but I think it looks pretty good. Should be able to do similar things for other images.

davidtwco commented 7 years ago

That looks really good, however, you're right in that the Javascript is starting to get a little bit out there.

I'd recommend splitting the content up into a collection - say, named chapters - and setting it such that items in the collection aren't output into their own pages and then, using attributes on the collection, you can define which chapters have images below them - ie. an image_below: gun.

Then in the template for the index page, just iterate over the items in the collection, checking for attributes and including partials that match the name of the image attribute, if there is one. Would result in a much cleaner result. I'd be happy to do this sometime tomorrow unless you want to take a shot at it.

TartanLlama commented 7 years ago

That sounds like a good idea, feel free to have a bash at it!

davidtwco commented 7 years ago

Re-opening this since #53 merged into this branch.