search

TaskarCenterAtUW / iOSPointMapper

4 stars 0 forks source link

Support multiple orientations #20

Open himanshunaidu opened 1 month ago

himanshunaidu commented 1 month ago

The Build settings only has Portrait mode supported. Other orientations need to be supported as well.

This would involve checking what code breaks when orientation changes to landscape or other orientations.

Also need to ensure that the frames (for camera, segmentation and annotation) are still working as expected. Currently, they might be relative to only the width

himanshunaidu commented 1 month ago

https://github.com/TaskarCenterAtUW/iOSPointMapper/blob/b93a57e211ea4e2f49269f466ca6e6a96948a867/IOSAccessAssessment/Camera/CameraManager.swift#L21-L23

himanshunaidu commented 1 month ago

This would mean that the getFrame methods created in the ViewControllers will also have to be changed to be more versatile.

Example: https://github.com/TaskarCenterAtUW/iOSPointMapper/blob/b93a57e211ea4e2f49269f466ca6e6a96948a867/IOSAccessAssessment/Camera/CameraViewController.swift#L55-L60