search

Tasshack / dreame-vacuum

Home Assistant integration for Dreame robot vacuums with map support
https://community.home-assistant.io/t/custom-component-dreame-vacuum
MIT License
777 stars 93 forks source link

Invalid "sensors must be cleaned warning" #399

Closed davidbeijinho closed 7 months ago

davidbeijinho commented 7 months ago

Describe the bug similar to https://github.com/Tasshack/dreame-vacuum/issues/311 i got a notification, but in the app this option is not available

To Reproduce after a clean i got a notification

Expected behavior this notification should not be visible

Screenshots notification image

Additional Information (please complete the following information)

Tasshack commented 7 months ago

I need the full model number not just name.

davidbeijinho commented 7 months ago

Dreame Bot W10, is this the correct value, of where should i get it?

Tasshack commented 7 months ago

From the device page at the top left.

davidbeijinho commented 7 months ago

found it, thanks

Majestic7979 commented 7 months ago

I also have the same, I was just using the service call to reset the sensor... and it resets it as expected. So this functionality is actually exposed in the firmware, but it's not in the app for some reason.

Tasshack commented 7 months ago

I also have the same, I was just using the service call to reset the sensor... and it resets it as expected. So this functionality is actually exposed in the firmware, but it's not in the app for some reason.

Most of the devices uses the same base firmware therefore all of them exposes the settings may not even have and normally everything is limited only from the App. This the general operation of the Dreame devices that's why it is so hard to make a project that supports all of their devices.

For example, if you try to enable the 'Wider corner coverage' option on the devices with telescopic mop arm, device will try to mop the floor like it does not have the arm, so it is important to integration to know which devices has that feature and does not populate the related entity. Same applies to the sensor cleaning requirement of the device as well.

Tasshack commented 7 months ago

Sensor cleaning is only a requirement for vacuums that has the 3D obstacle avoidance laser sensor.

Majestic7979 commented 7 months ago

Sensor cleaning is only a requirement for vacuums that has the 3D obstacle avoidance laser sensor.

The W10 most definitely have the sensors, trust me. It has LIDAR too. So the app actually has been implemented badly. But this is only FYI so you can adequately make the change in your code IF YOU WANT. I appreciate you've made this availability on a best-effort basis and I also appreciate that you maintain it promptly. Having this warning doesn't bother me, I just make the service call to reset and it's gone. What does bother me is how the manufacturer can't even program their app properly to account for the sensors in their own hardware, but that's not your fault.

Tasshack commented 7 months ago

It's not just the app is being badly implemented and firmware also. There are not checks for anything from the device firmware for the api so if the integration does something the device does not expect, it may even crash and reboot during a cleaning task. Also Dreame engineers only test the App and only what you can do from it so if I try to implement anything differently from the app, it is uncharted territory and they can't even know there is a problem. Because of that integration must and only operate exactly same with the app so I wrote a simple program to extract that information from all model plugins automatically (like sensor cleaning requirement). I will release a new Beta soon to fix all of the device capability related issues in the integration.

Tasshack commented 7 months ago

By the way this issue happens when they have add a feature to the firmware after it's release. The device got the updated firmware but Dreame did not bother to update the app plugin for the device because it takes too much time to test a new version of the plugin when device is near to its end of support which is 1 year for Dreame devices. I see this almost in every model that a device got new features with its firmware update but the App never updates to support them because it is EOL.

Majestic7979 commented 7 months ago

That's interesting to know, I like to know background info like that, very useful!! Thanks

Tasshack commented 7 months ago

Also all of the European models (called L series) are actually the Chinese models of previous year. I know this because there are no L series in the code, only S and X series are present and L series are actually the combination of S models with X docks and vice versa. So when you buy a European model from EU, it is much likely that it is already EOL or very close to it. Also every hardware they made actually has two models, one for EU/US and one for the CN market but they are exactly the same hardware/software with the exception of a region lock. Model numbers and names not related of those devices for make it harder for consumer to compare them in the market.

Majestic7979 commented 7 months ago

Also all of the European models (called L series) are actually the Chinese models of previous year. I know this because there are no L series in the code, only S and X series are present and L series are actually the combination of S models with X docks and vice versa. So when you buy a European model from EU, it is much likely that it is already EOL or very close to it. Also every hardware they made actually has two models, one for EU/US and one for the CN market but they are exactly the same hardware/software with the exception of a region lock. Model numbers and names not related of those devices for make it harder for consumer to compare them in the market.

Manufacturers are crazy. I suppose that they are using their Chinese customers as beta testers first, and if all goes well then they release to other regions. We don't get the W10 in the UK, so I imported mine from Germany. It's a great robot, it does a decent job of cleaning three types of different floors with no change required from me. Pretty much the only "issue" I have with it now is unable to reset the sensors from their app... It's really cool of you to share your knowledge like that, did you consider putting it in the Wiki or readme if not there already? I'm a geek so I love reading stuff like this :)

Tasshack commented 7 months ago

I don't think I can give more information without getting sued by the Dreame but thanks for the interest.

Tasshack commented 7 months ago

Fixed. https://github.com/Tasshack/dreame-vacuum/releases/tag/v2.0.0b12

Majestic7979 commented 7 months ago

Thank you man!!