Tasshack / dreame-vacuum

Home Assistant integration for Dreame robot vacuums with map support
https://community.home-assistant.io/t/custom-component-dreame-vacuum
MIT License
833 stars 103 forks source link

"Failed to call service" error after home asssitant 2024.5.0 #529

Closed thegabriele97 closed 5 months ago

thegabriele97 commented 5 months ago

Describe the bug If I select a mode (i.e. room, selection) and I click start, I receive the following error and the action doesn't start. It started when I upgraded to Home Assistant 2024.5.0

image

SvenJ76 commented 5 months ago

same here... came with the 2024.5.0 Update

rossmarkflo commented 5 months ago

Confirming this - is there any solution yet?

yousufinternet commented 5 months ago

I swear this will be the last time I update home-assistant

rossmarkflo commented 5 months ago

I swear this will be the last time I update home-assistant

Don't blame HA for this - they change things to make it better - if HACS addons like this one break it is not their responsibility. The developer(s) of the addon need to update their stuff to follow new guidelines.

I wished that software like SPOOK would catch these errors in the automations - and inform me about it - so I can be more pro-active. In this case I caught it cause my vacuums didn't start as expected..

Still - not blaming HA for it - nor the developer team here - it just needs to be aligned with current requirements and good. It's a domino effect that is absolutely normal - I am in IT 25+ years and coded enough on top of it - this is normal, might have been announced a while back - but not everyone has the time to read up on all the changes and review code - I am actually glad that this project here exists and someone is taking the time to look into it.

We don't appreciate the work of the HA nor all the addon developers enough at all! Heck, we don't even really pay them a penny for the most part.

To the DEV team here - hope you can fix this! And Thank you for all the work and TIME you put in! We all really appreciate it!

Tasshack commented 5 months ago

Update the integration to the latest version.

Tasshack commented 5 months ago

HA was actually doing it right by blocking the async requests inside threads because those will lead to memory corruption due to how python handles the situation.

rossmarkflo commented 5 months ago

Update the integration to the latest version.

Did you fix this in the 2.x versions as well? Seems like I have a 2.x installed and if I remember right it was because of the Dreame 10 or so having better support there...

Tasshack commented 5 months ago

@rossmarkflo issue was fixed on v1.0.4 and v2.0.0b14. If HACS telling you are using b14 and still getting the error then you should remove and reinstall the integration.

yousufinternet commented 5 months ago

I swear this will be the last time I update home-assistant

Don't blame HA for this - they change things to make it better - if HACS addons like this one break it is not their responsibility. The developer(s) of the addon need to update their stuff to follow new guidelines.

I wished that software like SPOOK would catch these errors in the automations - and inform me about it - so I can be more pro-active. In this case I caught it cause my vacuums didn't start as expected..

Still - not blaming HA for it - nor the developer team here - it just needs to be aligned with current requirements and good. It's a domino effect that is absolutely normal - I am in IT 25+ years and coded enough on top of it - this is normal, might have been announced a while back - but not everyone has the time to read up on all the changes and review code - I am actually glad that this project here exists and someone is taking the time to look into it.

We don't appreciate the work of the HA nor all the addon developers enough at all! Heck, we don't even really pay them a penny for the most part.

To the DEV team here - hope you can fix this! And Thank you for all the work and TIME you put in! We all really appreciate it!

I am not blaming homeassistant, I am blaming myself for being so eager to update without giving time to check if anything will break.. I agree with you