search

Tasshack / dreame-vacuum

Home Assistant integration for Dreame robot vacuums with map support
https://community.home-assistant.io/t/custom-component-dreame-vacuum
MIT License
887 stars 110 forks source link

add 2228z as an alternative to 2228o #769

Closed Krastanov closed 1 month ago

Krastanov commented 1 month ago

Resolves #734

An L10s Ultra from 6 months ago worked fine (2228o), but a newly bought one, from the very same Amazon listing, same make and model, turned out to be a 2228z

Krastanov commented 1 month ago

This single change does not seem to be enough. "Add Entry" now works, but the newly added entry just shows this:

image

Krastanov commented 1 month ago

I take that back. After waiting a few hours the vacuum seems to work fine. Could you please consider merging this?

Tasshack commented 1 month ago

Merging this wont be enough since private key and capabilities needs to be added also.

Krastanov commented 1 month ago

Could you elaborate a bit? Locally this PR works for me:

image

Krastanov commented 1 month ago

If there is some data you need me to extract from the new vacuum or from the app, let me know, happy to attempt to help with that.

Tasshack commented 1 month ago

Could you elaborate a bit? Locally this PR works for me:

Basic functionality will work but current map and some advanced features won't because integration needs to know capabilties for each model before generating specific entities with compatible option values. Some features for different generation of vacuums uses same parameter ids with different set of values and setting a parameter value that the vacuum does not expect can result unwanted behaviour and also break the app too.

If there is some data you need me to extract from the new vacuum or from the app, let me know, happy to attempt to help with that.

Adding new supported models to the integration is standard life cycle of maintaining the project and I have several custom tools for automating that procedure so you don't have to extract anything but thanks for asking to help.

You just have to wait for the next release...

steve-fraser commented 3 hours ago

@Tasshack any chance you will be adding this model soon?