Texts of Rime poems are not showing in the about pages

[emilianoricciardi]

This seems to have happened after we add a bunch of entries for the poems' About pages

[craigsapp]

This commit: https://github.com/TassoInMusicProject/tasso-website/commit/42ccc4b45f148d01735538885f1c3079a0b2baed allows for empty translations; otherwise, the page was not being built when the poem did not have a translation.

Example:

http://www.tassomusic.org/poem/?rime=23

[craigsapp]

I also need to implement multi-verse poem display...

http://www.tassomusic.org/poem/?rime=126

[craigsapp]

Here is an initial implementation of multiple-verse poems:

http://www.tassomusic.org/poem/?rime=126

How should long lines be treated? By shrinking the fontsize of all poems/translations, or by forcing a line wrap (probably with the wrapped text being indented a lot).

[emilianoricciardi]

Thanks, Craig! I think it's best to use a smaller font. Too many indents make the poem hard to read.

Emiliano

On Wed, Mar 21, 2018 at 12:57 PM, Craig Stuart Sapp < notifications@github.com> wrote:

Here is an initial implementation of multiple-verse poems:

http://www.tassomusic.org/poem/?rime=126

[image: screen shot 2018-03-21 at 5 59 11 pm] https://user-images.githubusercontent.com/3487289/37724463-22bb3a54-2d31-11e8-82af-7d564d9a9cdc.png

How should long lines be treated? By shrinking the fontsize of all poems/translations, or by forcing a line wrap (probably with the wrapped text being indented a lot).

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/TassoInMusicProject/tasso-website/issues/88#issuecomment-375016807, or mute the thread https://github.com/notifications/unsubscribe-auth/AZZl9zUr5FqY1JBy7RqXYTcdUAU67YTEks5tgoZjgaJpZM4SztZv .

[craigsapp]

I made the font smaller:

Probably if it is ever too long, then an indented line wrap could be the next step (but I don' t thing there are any at the moment).

Also: I enabled the next/previous single arrow buttons to browse through the poems (at the top of the page).

The double arrow is currently doing the same thing, but this will be changed to switch to musical settings, etc for a single poem.

[emilianoricciardi]

Hi Craig,

yes, this makes sense!

Emiliano

On Wed, Mar 21, 2018 at 2:20 PM, Craig Stuart Sapp <notifications@github.com

wrote:

Closed #88 https://github.com/TassoInMusicProject/tasso-website/issues/88.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/TassoInMusicProject/tasso-website/issues/88#event-1533925922, or mute the thread https://github.com/notifications/unsubscribe-auth/AZZl93EC2O-tjhXk5IWNpQd1GUnKLnx6ks5tgpnQgaJpZM4SztZv .

[emilianoricciardi]

Hi Craig,

some of the translations we will use are drawn from published sources, so we want to add publication fields for translations as well. Should I do it for all the poems, or just for those for which we will use published translations? In the latter case, I can add the fields myself, I think.

Emiliano

On Wed, Mar 21, 2018 at 3:28 PM, Emiliano Ricciardi < emilianoricciardi82@gmail.com> wrote:

Hi Craig,

yes, this makes sense!

Emiliano

On Wed, Mar 21, 2018 at 2:20 PM, Craig Stuart Sapp < notifications@github.com> wrote:

Closed #88 https://github.com/TassoInMusicProject/tasso-website/issues/88.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/TassoInMusicProject/tasso-website/issues/88#event-1533925922, or mute the thread https://github.com/notifications/unsubscribe-auth/AZZl93EC2O-tjhXk5IWNpQd1GUnKLnx6ks5tgpnQgaJpZM4SztZv .