Tasssadar / multirom

MultiROM for Nexus 7 and LG Optimus One
http://forum.xda-developers.com/showthread.php?t=2011403
GNU General Public License v3.0
415 stars 274 forks source link

Cannot disable adb #63

Open webgeek1234 opened 9 years ago

webgeek1234 commented 9 years ago

For some reason, adb cannot be disabled. I did some backtracing and the following line always returns zero: https://github.com/Tasssadar/multirom/blob/64d0205c45d320b80e84915d4cc8bd089965fe11/trampoline/adb.c#L239 no matter what the option is set to, causing adbd to always start. The command appears correct and copy-pasting the into a shell on the device results in the correct status being set.

The only reason I noticed this is due to another bug I haven't tracked down yet. Unless I stop adb from starting, it breaks adb/mtp/etc on the primary rom on roth (Nvidia Shield Portable, a Tegra 4 device). However, multirom stops adb correctly on the Shield Tablet, a Tegra K1 device, and the primary rom initializes adb/mtp correctly.