Tasssadar / multirom

MultiROM for Nexus 7 and LG Optimus One
http://forum.xda-developers.com/showthread.php?t=2011403
GNU General Public License v3.0
415 stars 274 forks source link

"implicit declaration of function 'free'" error when building in Omni 6.0 tree #74

Open zhuowei opened 8 years ago

zhuowei commented 8 years ago
target  C: multirom <= system/extras/multirom/multirom_ui.c
system/extras/multirom/multirom_ui.c: In function 'multirom_ui_tab_rom_destroy':
system/extras/multirom/multirom_ui.c:552:5: error: implicit declaration of function 'free' [-Werror=implicit-function-declaration]
     free(t);
     ^
system/extras/multirom/multirom_ui.c:552:5: warning: incompatible implicit declaration of built-in function 'free'
system/extras/multirom/multirom_ui.c: In function 'multirom_ui_tab_misc_destroy':
system/extras/multirom/multirom_ui.c:684:5: warning: incompatible implicit declaration of built-in function 'free'
     free(t);
     ^
cc1: some warnings being treated as errors
build/core/binary.mk:801: recipe for target '/home/zhuowei/android/out/target/product/angler/obj/EXECUTABLES/multirom_intermediates/multirom_ui.o' failed
make: *** [/home/zhuowei/android/out/target/product/angler/obj/EXECUTABLES/multirom_intermediates/multirom_ui.o] Error 1

this is with the latest master (1a55164)

Am I doing something wrong? (I'm using an old Omni 6.0 checkout from the end of December if that matters)

HashBang173 commented 8 years ago

You need to include some stuff, for this particular error you need to add #include <stdlib.h>

HashBang173 commented 8 years ago

This is a little bit messy, but I think it fixes the errors https://github.com/HashBang173/multirom/commit/f36fb7a371478b1ac58a88ee81dc4931933cff0c

zhuowei commented 8 years ago

Thanks - will give it a try.