Tastaturberuf / anyStores

Contao-Module: Organize any locations with geolocation search.
GNU Lesser General Public License v3.0
11 stars 7 forks source link

Allow null for coordinates #88

Closed fritzmg closed 3 years ago

fritzmg commented 3 years ago

Should fix https://community.contao.org/de/showthread.php?81293-Nach-Serverumzug-kann-ich-keine-neuen-Mdoule-mehr-erstellen-anystores-Fehler&p=546702#post546702

Alternatively the definition could be "float(10,6) NOT NULL default 0.0", but I think allowing NULL makes more sense in this case?

Tastaturberuf commented 3 years ago

In my unreleased 2.0 bundle have fixed this as default 0. I think the JavaScript broke with null values.

gassi101 commented 3 years ago

So this was my post. So i can change the file in vendors directory? Or what do i have to do? Greetz Frank

Tastaturberuf commented 3 years ago

No. I make a new release and you can update with composer or Contao Manager.

Tastaturberuf commented 3 years ago

Thanks @fritzmg

Tastaturberuf commented 3 years ago

I see it was fixed with https://github.com/Tastaturberuf/anyStores/commit/2e1c19728eb889601d712d188dd7e8a426dd8870

Tastaturberuf commented 3 years ago

@gassi101 Which version you have installed? 1.13 has fixed this error.

gassi101 commented 3 years ago

Hey, i have Version 1.13 - and contao 4.9.16.

gassi101 commented 3 years ago

But in my tl_module.php there is 'anystores_latitude' => array ( 'label' => &$GLOBALS['TL_LANG']['tl_module']['anystores_latitude'], 'exclude' => true, 'inputType' => 'text', 'eval' => array ( 'mandatory' => true, 'default' => 0, 'maxlength' => 64, 'tl_class' => 'w50' ), 'sql' => "float(10,6) NOT NULL"

Tastaturberuf commented 3 years ago

I see the error, must fix this in tl_module too.

Tastaturberuf commented 3 years ago

I have released 1.13.1

thank you both @gassi101 @fritzmg

gassi101 commented 3 years ago

Hey Thank you, is this update already in the contao manager ? Can i make an update for this module?

Tastaturberuf commented 3 years ago

yes it should be there.

Gassi @.***> schrieb am Di., 20. Juli 2021, 13:48:

Hey Thank you, is this update already in the contao manager ? Can i make an update for this module?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/Tastaturberuf/anyStores/pull/88#issuecomment-883328336, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAH23QPAPJ75AEJO3TOCVYDTYVPAZANCNFSM5AVRPJDA .

gassi101 commented 3 years ago

Hey, sorry that i had to write again ;-( i only see the 1.13 Version in the manager. Or must i type in the new Version of the module "1.31.1! ?

fritzmg commented 3 years ago

@gassi101 you need to wait a while after a fresh release, because it might take a while until packagist knows abtout the new version. And it might take even longer for the package list in the Contao Manager to show that a new version is available.

All you need to do is select the package to be updated and apply the changes.

Tastaturberuf commented 3 years ago

Best way ist to use ^1.13. If it is listet here (it is) it should be installed by a composer update.

Tastaturberuf commented 3 years ago

If you are unsure try the Dry-run feature. You can see what will be updated but is change no files really.