search

Tastrainee / google-refine

Automatically exported from code.google.com/p/google-refine
Other
0 stars 0 forks source link

Line based importer needs to keep Quotation Marks with separators #420

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
New "Line-based text file" importer seems to work OK.

Would be useful to keep functionality same as CSV/TSV for "Quotation marks are 
used to enclose cells containing column separators"

Attached test file as example.  Ignore 1st line, every 4 lines.

Original issue reported on code.google.com by thadguidry on 18 Jul 2011 at 2:35

Attachments:

GoogleCodeExporter commented 9 years ago 
I think that's actually a bug.  We shouldn't be stripping leading and trailing 
quotes unless they're the only quotes in the field (and arguably not even then).

Original comment by tfmorris on 5 Nov 2011 at 4:23

GoogleCodeExporter commented 9 years ago 
Agree.  I was asking to make the "Line-based importer" also have the checkbox 
option to strip or keep outer quotes for fields.  It appears that this isn't 
even the case as you stated!  The function "Quotation marks are used to enclose 
cells containing column separators" is a question we are asking the user, 
instead of describing the function we are going to apply: Strip outer quotes 
(Yes/No).  Regardless, we need to have a checkbox option on both Line-based and 
CSV/TSV importers, where the user has a choice to keep outer quotes or not.  
Does everyone agree on that issue ?

Original comment by thadguidry on 5 Nov 2011 at 5:06

GoogleCodeExporter commented 9 years ago 
So, from what I understand, we need 2 different checkboxes:
1. Quotation marks are used to enclose cells containing column separators 
(default: on)
2. (Only available if checkbox 1 is on) Strip out such quotation marks 
(default: on)
Is that correct?

Original comment by dfhu...@gmail.com on 5 Nov 2011 at 7:35

GoogleCodeExporter commented 9 years ago 
Yes, I think having both those options would make Refine very flexible and 
comparable to other tools that have similar options.  Granted, it's something 
that you also need to have the option of putting the Quotes back into place 
upon export operations...which I think we have already, correct?

Original comment by thadguidry on 6 Nov 2011 at 3:07

GoogleCodeExporter commented 9 years ago

Original comment by tfmorris on 7 Sep 2012 at 9:34

GoogleCodeExporter commented 9 years ago

Original comment by tfmorris on 18 Sep 2012 at 5:48

GoogleCodeExporter commented 9 years ago

Original comment by tfmorris on 18 Sep 2012 at 5:52