Tater-Certified / Potatoptimize

Let Tater optimize your game! It may be more potato than vanilla when it is done!
GNU General Public License v3.0
15 stars 1 forks source link

Improve readme file clarity #32

Open yizexiaomu opened 1 month ago

yizexiaomu commented 1 month ago

I am glad that the author dared to try very aggressive optimization on Fabric, but it is worth noting that in terms of optimization, server-side optimization such as Paper and Folia clearly have stronger stability and better optimization, and Folia has even achieved a very stable level in terms of multithreading. Therefore, I would like to politely ask the author whether the future update direction of this mod is to perform aggressive optimization on Fabric while minimizing the impact on the original version or to optimize it without considering the original features. This really has great reference value for the Fabric mod ecosystem! Thank you for the author's response!

QPCrummer commented 1 month ago

This mod just ports some patches from Paper and forks over to Fabric? Fabric is already ahead of PaperMC in terms of raw performance (except scaleability). I wouldn’t be interested in using anything from Folia as the minimum requirements for Folia are honestly ridiculous for a common server owner. This mod is just some minor performance improvements in niche cases typically. I’m not trying to “get rid of Paper” or “make Paper on Fabric”. And honestly, this mod does have some improvements over Paper that I wish Paper would adopt, such as extremely fine customization in terms of the optimizations offered. This mod allows every single optimization to be enabled and disabled through out config with a wiki documenting the basic use of the optimizations.

If you have any more questions. Feel free comment then below and I will reply as soon as possible. Thank you.

yizexiaomu commented 1 month ago

So, do you mean that most of the functions of this mod will still affect some of the features of the vanilla version

QPCrummer commented 1 month ago

I would say about 50% of the optimizations technically alter vanilla mechanics. That being said, if it is a significant change that typically player would notice, then the optimization is disabled by default. If there is a noticeable difference between vanilla and this mod with a default config, then I would consider it a bug (like for example, there is an issue with lightning not spawning as frequently. It seems to be an issue with one of the PaperMC patches I ported to Mixin. I have to do them all by hand, so I'd expect mistakes here and there.)

yizexiaomu commented 1 month ago

Will optimizing code such as multi-threaded entity loading and explosion asynchrony still have a significant impact on vanilla?

QPCrummer commented 1 month ago

Well currently multithreaded entities will significantly impact your game cause it will immediately crash :P It's disabled in the "unstable" package because of this. And yes, async explosions will also noticeably affect vanilla mechanics. It has a tendency to not blow up an entire chunk of tnt. I believe it is also in the "unstable" package too.

yizexiaomu commented 1 month ago

Have you considered adding a multi-threaded module like this mod https://github.com/WearBlackAllDay/DimensionalThreading

QPCrummer commented 1 month ago

I may implement something similar to this: https://github.com/2No2Name/worldthreader

I'll have to ask 2No for permission first though

yizexiaomu commented 1 month ago

Thank you for your answer! I have no further questions, you can close this issues

QPCrummer commented 1 month ago

Actually I'm going to keep it open because this will remind me to improve my readme file

yizexiaomu commented 1 month ago

Actually I'm going to keep it open because this will remind me to improve my readme file

This should be a better way of handling it By the way I may also continue to provide suggestions for this mod in the future

QPCrummer commented 1 month ago

Ok, thank you very much