search

Tater-Certified / Potatoptimize

Let Tater optimize your game! It may be more potato than vanilla when it is done!
GNU General Public License v3.0
11 stars 1 forks source link

Compability with Stutterfix? #8

Open Rad586 opened 1 month ago

Rad586 commented 1 month ago

https://modrinth.com/mod/stutterfix Stutterfix tweaks worker threads count and thread priority, but potatoptimize replaces worker thread(mixin.logic.worker_thread) and tweaks resource values(mixin.logic.main_thread). I was wondering if they work well with each other. Since I have no experience of modding, I tested using spark: image image Seems the Worker-Main thread was replaced by PotatoptimizeWorkerThread-Main with less counts.

Also, smoothboot tweaks the count of threads, and modernfix tweaks the priority of threads, I was also wondering if these features are compatible with potatoptimize.

QPCrummer commented 1 month ago

I also tweak the priority of the threads after I replace them. Modernfix may try to change the priority of the original thread, but it shouldn't affect anything as that thread is not used anymore.

Additionally, if Modernfix is present, mixin.logic.worker_thread disables itself as it has similar code that is probably higher quality overall than my implementation.

I'm not sure if stutterfix would be beneficial in this case. Since thread priority is already set by my mod, it probably won't be changed by stutterfix. I suppose it could alter the amount of threads present, but I'm not sure if it'd be compatible with my implementation.