Tatoeba / tatoeba2

Tatoeba is a platform whose purpose is to create a collaborative and open dataset of sentences and their translations.
https://tatoeba.org
GNU Affero General Public License v3.0
714 stars 132 forks source link

Issue 3004 - Change input name for 'username' search to avoid signin auto-fill popup #3005

Closed vinkaks closed 2 years ago

vinkaks commented 2 years ago

This PR is an attempt to fix #3004

REQUIRES TESTING ON SAFARI BROWSER (I don't have a iOS device.)

Safari/iOS users face a disruptive sign-in suggestion pop-up when they land on or attempt to fill in the username search form on https://tatoeba.org/en/users/all. Same issue observed but not as disruptive on other browsers.

Attempt to solve by

Yorwba commented 2 years ago

I don't have an iOS device to test this on, but the changes make sense to me and at least in Firefox the context menu stops suggesting to manage logins and allows setting a search keyword instead. Once this is deployed, mramosch can test whether this works in Safari as well.