search

Tatoeba / tatoeba2

Tatoeba is a platform whose purpose is to create a collaborative and open dataset of sentences and their translations.
https://tatoeba.org
GNU Affero General Public License v3.0
714 stars 132 forks source link

Can't edit transcription on sentences with audio #3006

Closed DJ-Saidez closed 1 year ago

DJ-Saidez commented 2 years ago

Steps to reproduce the behavior:

  1. Go to https://tatoeba.org/en/sentences/show/11211585 which is a Japanese sentence with audio. The software-generated transcription is incorrect (おひゃくどせき should be おひゃくどいし), and I want to change it.
Screen Shot 2022-10-28 at 8 02 50 PM
  1. Click on the pencil icon to edit the transcription.
Screen Shot 2022-10-28 at 8 03 12 PM
  1. See error

Normally, when I click on the pencil icon, I'm able to edit or confirm the transcription (which doesn't affect the actual sentence text), even though I don't own the sentence. The fact that it has audio, logistically, shouldn't affect its ability to be modified to match the audio better.

I'm using Google Chrome on Mac 12.4.

DJ-Saidez commented 2 years ago

Update: The example sentence was edited by a corpus maintainer.

To see the error again, try this sentence https://tatoeba.org/en/sentences/show/11211978

vinkaks commented 2 years ago

I think only edits to the original sentence should be disabled once audio is added. Transcripts should still be editable for such use cases as yours.

I think we can just disable the sentence input. Using something like ng-disabled and otherwise let the form work. Will do a PR with a fix