Disable jump to top - Githubissues

Tatoeba / tatoeba2

Tatoeba is a platform whose purpose is to create a collaborative and open dataset of sentences and their translations.

https://tatoeba.org

GNU Affero General Public License v3.0

714 stars 132 forks source link

Disable jump to top #3014

Closed vinkaks closed 1 year ago

vinkaks commented 2 years ago

Attempt to fix #3011

Steps to solve

edit the controller so that it stops scrolling to top of body
Edit sidenav so that it is fixed to viewport, not absolutely positioned relative to body

Tested on search sentences/search page and show sentences sentences/show/:id page

https://user-images.githubusercontent.com/21044267/200612482-ba0206fe-187e-47a8-bae6-c230edd33be0.mov

jiru commented 1 year ago

Thank you, @vinkaks! It works for me and the fix looks clean.

The only comment I have is about code style. In the CSS, you could add spaces before opening brackets so that the style matches with the rest of the file.