search

Tatoeba / tatoeba2

Tatoeba is a platform whose purpose is to create a collaborative and open dataset of sentences and their translations.
https://tatoeba.org
GNU Affero General Public License v3.0
678 stars 131 forks source link

@change, and other @ tags, needlessly carried over to merged sentences #3088

Open morbrorper opened 7 months ago

morbrorper commented 7 months ago

If a sentence that has a @change tag is changed, and the change results in a merge with another sentence, the tag is copied to the remaining sentence. This leads to a confusing state that can only be corrected by the owner of the tag, if they happen to notice, or an admin.

Of course, this applies to all @ tags, such as @needs_native_check.

Suggested solution: Make Horus exclude tags prefixed with "@" in copying tags when merging sentences.

I've deliberately labelled this a bug, even though Horus is just doing its job, as I consider it a bug in how Tatoeba works.

ckjpn commented 6 months ago

Related: https://github.com/Tatoeba/tatoeba2/issues/2595 It's closed

See AndiPersti commented on Dec 17, 2020

morbrorper commented 6 months ago

Related: #2595 It's closed

Yes, related, but not identical, as this only concerns special tags, prefixed with "@".

ckjpn commented 6 months ago

AndiPersti's comment further refers to this comment on another issue that is related.

https://github.com/Tatoeba/tatoeba2/issues/1830#issuecomment-583591293