Add "unknown" audio contributor text when author is null

[cblanken]

This PR solves issue #2551 On the sentences/show/<id> page conditionally render "unknown" for the audio contributor field when an audio has no associated user.

Before

After

[jiru]

Great! I think it would look even better using an alternative text such as "unknown author" instead of "by unknown". "by unknown" feels like robot talk.

[cblanken]

Great! I think it would look even better using an alternative text such as "unknown author" instead of "by unknown". "by unknown" feels like robot talk.

@jiru do you mean I should remove the attribution text "by" as well like this?

or add "author" to the existing text like this?

I think it may also make sense to make the "unknown user" text red in contrast to the green text used for an existing user. Like this

Thoughts?

[jiru]

do you mean I should remove the attribution text "by" as well like this?

Yes that’s what I meant. My point is that "by" is normally followed by a name or a pronoun, but "unknown" is not a name, it’s an adjective, so it sounds weird to me. If you want to keep "by", then "by an unknown author" is correct English I think. Sorry I’m just very picky when it comes to syntax :zany_face:

I think it may also make sense to make the "unknown user" text red in contrast to the green text used for an existing user.

I think plain red color should be limited to express serious warnings, danger etc. See for example how Github uses red in "Delete account" of https://github.com/settings/admin, "Delete" key button of https://github.com/settings/keys. In my opinion the absence of green and absence of hyperlink is appropriate to mean "something’s missing here".

[jiru]

Thank you :+1: