search

TatriX / pomidor

Pomidor is a simple and cool pomodoro technique timer.
238 stars 17 forks source link

Endless loop of warning "This Emacs binary lacks sound support" #24

Closed rnkn closed 6 years ago

rnkn commented 6 years ago

The function pomidor-play-sound-file-emacs, which appears to be called once per second, will raise a warning upon each call if play-sound-internal is unbound, which it is for GUI and console Emacs 26.1 on macOS.

https://github.com/TatriX/pomidor/blob/30004b21714b53d22041514d905e1876c5cedd4b/pomidor.el#L115

Deleting this line resolves the problem.

rnkn commented 6 years ago

Excellent package btw.

TatriX commented 6 years ago

Thank you. You can override that. If you think it should be handled differently, please feel free to reopen the issue.

rnkn commented 6 years ago

Ah I see, thanks. I'd only suggest this might be better as a defcustom.

(I think GitHub change a while back and only you can reopen issues these days.)

TatriX commented 6 years ago

Yes, sounds like a good idea. PR is welcome ;)

TatriX commented 6 years ago

Closed by #25