search

TatriX / pomidor

Pomidor is a simple and cool pomodoro technique timer.
239 stars 17 forks source link

Fix snooze time formating error #45

Closed wandersoncferreira closed 4 years ago

wandersoncferreira commented 4 years ago

This PR removes the formating time of the :snooze variable as it is a boolean. Fixes #44

wandersoncferreira commented 4 years ago

@TatriX I tested the behavior of time-equal-p and equal produced the same one and is back-compatible with older emacs versions. Several minor issues bc I was using Emacs 27 and had no checked if the functions existed in older versions. :/

Have you thought about implementing a test suite? I have never done one in elisp, but maybe would be a good attempt.

TatriX commented 4 years ago

Have you thought about implementing a test suite?

Not really, because it used to be mostly "frontend" app and its hard to test visuals. But sure, it makes sense to add some tests. I would probably look at buttercup or ecukes and of course ert